Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper new node placement #8069

Closed
Tracked by #7685
farmaazon opened this issue Oct 16, 2023 · 3 comments · Fixed by #8112
Closed
Tracked by #7685

Proper new node placement #8069

farmaazon opened this issue Oct 16, 2023 · 3 comments · Fixed by #8112
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Oct 16, 2023

If done before #8054, just the functions returning position should be implemented.

It should be implemented as in the old design, except the following:

  1. The "Previous node dictated placement" should look for place to the right, not to the left
  2. "Mouse pointer dictated placement" should work differently, as previously it gave a very bad UX. May be always create node as pointed position (as eventually in the old GUI), or other improvements may be discussed.
@farmaazon farmaazon mentioned this issue Oct 16, 2023
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints -gui labels Oct 16, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Oct 16, 2023
@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board Oct 19, 2023
@somebody1234 somebody1234 mentioned this issue Oct 19, 2023
5 tasks
@enso-bot
Copy link

enso-bot bot commented Oct 20, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-10-20):

Progress: - tests

  • lots of debugging and bugfixes
  • big refactor It should be finished by 2023-10-27.

Next Day: (hopefully) finish new node placement (only one test should be left), do bookclub

@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Oct 23, 2023
@enso-bot
Copy link

enso-bot bot commented Oct 23, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-10-23):

Progress: - finish implementing

other issues -

  • merge demo scenes, basic testing with building static site
  • investigate issue with broken font paths on website2 It should be finished by 2023-10-27.

Next Day: website2 things, reading custom visualizations (+ potentially refactors to viz compiler - currently it fetches dependencies), actually do bookclub...

@enso-bot
Copy link

enso-bot bot commented Oct 24, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-10-24):

Progress: - (wip) address issues

  • minor issues are addressed locally
  • the tests need quite major refactors
  • one file is also still missing tests

other issues -

  • (8077, no PR yet) initial implementation for loading custom visualizations (logic mostly done? this includes refactors to viz compiler). current status: working on subscribing to file updates It should be finished by 2023-10-27.

Next Day: finish addressing issues, attempt to finish loading custom visualizations, i can probably actually do bookclub tomorrow

@mergify mergify bot closed this as completed in #8112 Oct 30, 2023
mergify bot pushed a commit that referenced this issue Oct 30, 2023
- Closes #8069

# Important Notes
None
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Oct 30, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants