-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize suggestions database only once in the presence of multiple clients #8033
Comments
Dmitry Bushev reports a new STANDUP for yesterday (2023-10-12): Progress: Starting working on the task. Reproduced the issue in a new IDE. Identified the issue with the initialization components. Finishing the work on PR with the panic visualizations It should be finished by 2023-10-17. Next Day: Next day I will be working on the #8033 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for today (2023-10-13): Progress: Continue working on the task. Implemented an execution flag for the initialization components. This caused an issue with a bunch of the language server tests because they re-use the same JSON controller for multiple tests in the suite that should be initialized each time. Started working on the fix It should be finished by 2023-10-17. Next Day: Next day I will be working on the #8033 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for yesterday (2023-10-16): Progress: Continue working on the task. Fixed the tests. Implemented blocking initialization of resouces. Found an issue with applying the suggestion database update. Stared debugging the suggestions handler. It should be finished by 2023-10-17. Next Day: Next day I will be working on the #8033 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for today (2023-10-17): Progress: Continue working on the task. Found an issue with getSuggestionsDatabase command handling. Implemented unique background jobs. Fixed the logic of InvalidateModulesIndexCommand. Tested in a new ide. It should be finished by 2023-10-17. Next Day: Next day I will be working on the #8033 task. Continue working on the task |
Dmitry Bushev reports a new 🔴 DELAY for yesterday (2023-10-18): Summary: There is 3 days delay in implementation of the Initialize suggestions database only once in the presence of multiple clients (#8033) task. Delay Cause: Fixed various issues with the asynchronous language server initialization and suggestions handling in the new IDE. Refactored the initialization logic to Java. |
Dmitry Bushev reports a new STANDUP for yesterday (2023-10-18): Progress: Continue working on the task. Refactored blocking initialization component in Java. Refactored the initialization logic from Scala futures to Java. Fixed the message sequence when handling the getSuggestionsDatabase message. It should be finished by 2023-10-20. Next Day: Next day I will be working on the #8033 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for today (2023-10-19): Progress: Continue working on the task. End up refactoring the initialization logic to Java. Fixed the language server tests. Fixed the initialization of background processing in the new IDE. Fixed the language server tests. Started testing in the IDE. It should be finished by 2023-10-20. Next Day: Next day I will be working on the #8033 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for yesterday (2023-10-20): Progress: Continue working on the task. Fixed review comments. Fixed runtime tets. Tested once again in both IDEs. It should be finished by 2023-10-20. Next Day: Next day I will be working on the #8033 task. Continue working on the task |
close #8033 Changelog: - update: run language server initialization once - fix: issues with async `getSuggestionDatabase` message handling in new IDE - update: implement unique background jobs - refactor: initialization logic to Java - refactor: `UniqueJob` to a marker interface
Once initialization problems have been fixed in #7985 I discovered that suggestion database would often crash for no apparent reason:
To reproduce:
npm --workspace=enso-gui2 run dev
(andnpm install
if you haven't done it before)The problem will occur either during a simple startup of a project or if you attempt to move around some of the nodes, causing edits.
The text was updated successfully, but these errors were encountered: