Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change filter_blank_rows when_any parameter to have a more user-friendly type #7931

Closed
radeusgd opened this issue Sep 29, 2023 · 6 comments · Fixed by #7935
Closed

Change filter_blank_rows when_any parameter to have a more user-friendly type #7931

radeusgd opened this issue Sep 29, 2023 · 6 comments · Fixed by #7935
Assignees
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request

Comments

@radeusgd
Copy link
Member

The parameter when_any is currently a Boolean, so the invocations look like:

table.filter_blank_rows when_any=True
table.filter_blank_rows when_any=False

It is not immediately clear what is the meaning of each when_any setting.

We can instead, change the Boolean type to a sum type with constructors: Any_Cell_Blank and All_Cells_Blank that could make this a bit clearer.

table.filter_blank_rows when=Any_Cell_Blank
table.filter_blank_rows when=All_Cells_Blank

We should also apply the same transformation to select_blank_columns and remove_blank_columns for consistency.

@radeusgd radeusgd added x-new-feature Type: new feature request -libs Libraries: New libraries to be implemented labels Sep 29, 2023
@radeusgd radeusgd moved this from ❓New to 📤 Backlog in Issues Board Sep 29, 2023
@Cassandra-Clark Cassandra-Clark moved this from 📤 Backlog to 🔧 Implementation in Issues Board Sep 29, 2023
@Cassandra-Clark Cassandra-Clark moved this from 🔧 Implementation to 👁️ Code review in Issues Board Sep 29, 2023
@enso-bot
Copy link

enso-bot bot commented Sep 29, 2023

Cassandra Clark reports a new STANDUP for today (2023-09-29):

Progress: filter_blank_rows changes complete and pr submitted It should be finished by 2023-09-30.

Next Day: fraud demo

@enso-bot
Copy link

enso-bot bot commented Oct 30, 2023

Cassandra Clark reports a new 🔴 DELAY for today (2023-10-30):

Summary: There is 31 days delay in implementation of the Change filter_blank_rows when_any parameter to have a more user-friendly type (#7931) task.
It will cause 1 day delay for the delivery of this weekly plan.

Delay Cause: Rebase and CI issues not reproducible on desktop

@enso-bot
Copy link

enso-bot bot commented Oct 30, 2023

Cassandra Clark reports a new STANDUP for today (2023-10-30):

Progress: filter_blank_rows pr issue remediation, fraud demo recording. It should be finished by 2023-10-31.

Next Day: close out pr, book club

@mergify mergify bot closed this as completed in #7935 Nov 1, 2023
mergify bot pushed a commit that referenced this issue Nov 1, 2023
…dly type (#7935)

Added Blank_Selector constructor and applied to remove_blank_columns, select_blank_columns, filter_blank_rows for #7931 . Changed when_any to when for readability.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Nov 1, 2023
@enso-bot
Copy link

enso-bot bot commented Nov 7, 2023

Cassandra Clark reports a new STANDUP for the provided date (2023-10-02):

Progress: made changes based on pr feedback, made progress on fraud demo It should be finished by 2023-10-31.

Next Day: fraud demo

@enso-bot
Copy link

enso-bot bot commented Nov 7, 2023

Cassandra Clark reports a new STANDUP for the provided date (2023-10-03):

Progress: finalize tests for 7931, fraud demo work, book club for this week It should be finished by 2023-10-31.

Next Day: publish book club, fraud demo work, wrap up 7931

@enso-bot
Copy link

enso-bot bot commented Nov 7, 2023

Cassandra Clark reports a new STANDUP for the provided date (2023-10-05):

Progress: finished tests for 7931 It should be finished by 2023-10-31.

Next Day: fraud demo work, wrap up 7931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants