-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change filter_blank_rows
when_any
parameter to have a more user-friendly type
#7931
Comments
Cassandra Clark reports a new STANDUP for today (2023-09-29): Progress: filter_blank_rows changes complete and pr submitted It should be finished by 2023-09-30. Next Day: fraud demo |
Cassandra Clark reports a new 🔴 DELAY for today (2023-10-30): Summary: There is 31 days delay in implementation of the Change Delay Cause: Rebase and CI issues not reproducible on desktop |
Cassandra Clark reports a new STANDUP for today (2023-10-30): Progress: filter_blank_rows pr issue remediation, fraud demo recording. It should be finished by 2023-10-31. Next Day: close out pr, book club |
Cassandra Clark reports a new STANDUP for the provided date (2023-10-02): Progress: made changes based on pr feedback, made progress on fraud demo It should be finished by 2023-10-31. Next Day: fraud demo |
Cassandra Clark reports a new STANDUP for the provided date (2023-10-03): Progress: finalize tests for 7931, fraud demo work, book club for this week It should be finished by 2023-10-31. Next Day: publish book club, fraud demo work, wrap up 7931 |
Cassandra Clark reports a new STANDUP for the provided date (2023-10-05): Progress: finished tests for 7931 It should be finished by 2023-10-31. Next Day: fraud demo work, wrap up 7931 |
The parameter
when_any
is currently aBoolean
, so the invocations look like:It is not immediately clear what is the meaning of each
when_any
setting.We can instead, change the Boolean type to a sum type with constructors:
Any_Cell_Blank
andAll_Cells_Blank
that could make this a bit clearer.We should also apply the same transformation to
select_blank_columns
andremove_blank_columns
for consistency.The text was updated successfully, but these errors were encountered: