Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node selection #7865

Closed
Tracked by #7685
farmaazon opened this issue Sep 21, 2023 · 1 comment · Fixed by #7893
Closed
Tracked by #7685

Node selection #7865

farmaazon opened this issue Sep 21, 2023 · 1 comment · Fixed by #7893
Assignees
@somebody1234
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Sep 21, 2023 •
edited by somebody1234
Loading

Implement all ways of selecting nodes from old UI. See "Node selection" section of this document for reference.
@farmaazon farmaazon mentioned this issue Sep 21, 2023
Closed
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint -gui labels Sep 21, 2023
@farmaazon farmaazon added p-medium Should be completed in the next few sprints and removed p-high Should be completed in the next sprint labels Sep 25, 2023
@somebody1234 somebody1234 mentioned this issue Sep 26, 2023
Merged
5 tasks
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Sep 26, 2023
@farmaazon farmaazon moved this from 📤 Backlog to 👁️ Code review in Issues Board Sep 26, 2023
@enso-bot
Copy link

enso-bot bot commented Sep 28, 2023

E-Hern Lee reports a new STANDUP for today (2023-09-28):

Progress: - fix focus/events not being triggered

  • fixez for selection brush when zoomed in
  • change all @click handlers to @pointerdown.stop handlers
  • hide circle cursor when a system cursor is visible

shortcuts changes -

  • switch viz to new shortcuts api
  • minor refactor of viz builtin modules It should be finished by 2023-10-04.

@mergify mergify bot closed this as completed in #7893 Oct 2, 2023
mergify bot pushed a commit that referenced this issue Oct 2, 2023
@somebody1234
[gui2] Shortcut manager + shortcuts for selecting nodes (#7893)
b59e7c0 
- Closes #7874
- Chosen solution: Use the dashboard's shortcut manager to register keybinds and match mouse shortcuts
- Switch existing shortcuts to shortcut manager as well
- Switch visualizations to use the shortcut manager too
- Closes #7865
- Implements all shortcuts for node selection, *except* the arrow key shortcut
- Adds circle cursor selection brush
- The fade out from inactivity (which is present in the Rust source code) is currently missing

Other changes:
- Change everything to use `pointerdown` as appropriate, to ensure the event handlers are called in the right order

# Important Notes
The arrow key shortcut to navigate to the nearest node in that direction *has not* been implemented.
This may need discussion on how it should work

The implementation in general is pretty inefficient - this is intentional, performance can be optimized in the future
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Oct 2, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@somebody1234 somebody1234

Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[gui2] Shortcut manager + shortcuts for selecting nodes enso-org/enso
2 participants
@farmaazon @somebody1234