Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edges interactions #7864

Closed
Tracked by #7685
farmaazon opened this issue Sep 21, 2023 · 8 comments · Fixed by #8138
Closed
Tracked by #7685

Edges interactions #7864

farmaazon opened this issue Sep 21, 2023 · 8 comments · Fixed by #8138
Assignees
@kazcw
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Sep 21, 2023 •
edited
Loading

Creating new edge, disconnecting and reconnecting should be supported. The changes in code should be done only once user finish the operation (discard connection or reconnect), like in the old GUI.

Creating new node from dragging-out connection is not in the scope of this task.
@farmaazon farmaazon mentioned this issue Sep 21, 2023
Closed
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint -gui p-medium Should be completed in the next few sprints and removed p-high Should be completed in the next sprint labels Sep 21, 2023
@kazcw kazcw self-assigned this Sep 29, 2023
@kazcw kazcw moved this from ❓New to 🔧 Implementation in Issues Board Sep 29, 2023
@kazcw kazcw linked a pull request Sep 29, 2023 that will close this issue
Disconnected edges #7922
Closed
5 tasks
@enso-bot
Copy link

enso-bot bot commented Sep 29, 2023

Keziah Wesley reports a new STANDUP for yesterday (2023-09-27):

Progress: Started implementing edge disconnect. It should be finished by 2023-10-03.

Next Day: Next day I will be working on the #7864 task. Finish disconnected state.

@enso-bot
Copy link

enso-bot bot commented Sep 29, 2023

Keziah Wesley reports a new STANDUP for today (2023-09-28):

Progress: Implemented disconnected state, cancellation, hover snapping. It should be finished by 2023-10-03.

Next Day: Next day I will be working on the #7864 task. Output ports, edge creation.

@kazcw kazcw removed a link to a pull request Oct 13, 2023
Disconnected edges #7922
Closed
5 tasks
@kazcw kazcw mentioned this issue Oct 13, 2023
Closed
5 tasks
@enso-bot enso-bot bot mentioned this issue Oct 18, 2023
Closed
@enso-bot
Copy link

enso-bot bot commented Oct 20, 2023

Keziah Wesley reports a new 🔴 DELAY for yesterday (2023-10-18):

Summary: There is 17 days delay in implementation of the Edges interactions (#7864) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Interrupted by more pressing parser tasks.

@enso-bot
Copy link

enso-bot bot commented Oct 20, 2023

Keziah Wesley reports a new STANDUP for yesterday (2023-10-18):

Progress: Implementing edge edits. It should be finished by 2023-10-20.

Next Day: Next day I will be working on the #7864 task. Continue edits.

@enso-bot
Copy link

enso-bot bot commented Oct 20, 2023

Keziah Wesley reports a new STANDUP for today (2023-10-19):

Progress: Finished edge actions, started porting layout algorithm from Rust. It should be finished by 2023-10-20.

Next Day: Next day I will be working on the #7864 task. Finish visual details.

@enso-bot
Copy link

enso-bot bot commented Oct 24, 2023

Keziah Wesley reports a new STANDUP for the last Friday (2023-10-20):

Progress: Finished porting layout algorithm. Implemented hover splitting. It should be finished by 2023-10-20.

Next Day: Next day I will be working on the #7864 task. Various rendering fine-tuning, then start next task.

@enso-bot
Copy link

enso-bot bot commented Oct 24, 2023

Keziah Wesley reports a new 🔴 DELAY for today (2023-10-23):

Summary: There is 3 days delay in implementation of the Edges interactions (#7864) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Implementing a lot of little features to match our old edges.

@enso-bot
Copy link

enso-bot bot commented Oct 24, 2023

Keziah Wesley reports a new STANDUP for today (2023-10-23):

Progress: Implemented output ports, hover extensions, backward-edge arrows. It should be finished by 2023-10-23.

Next Day: Next day I will be working on the #8073 task. Start execution-modes.

@kazcw kazcw mentioned this issue Oct 24, 2023
Merged
4 tasks
@kazcw kazcw linked a pull request Oct 24, 2023 that will close this issue
Edge interactions and rendering #8138
Merged
4 tasks
@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Oct 24, 2023
@mergify mergify bot closed this as completed in #8138 Oct 25, 2023
mergify bot pushed a commit that referenced this issue Oct 25, 2023
@kazcw
Edge interactions and rendering (#8138)
ea487a9 
[vokoscreenNG-2023-10-23_06-35-31.webm](https://github.com/enso-org/enso/assets/1047859/d8a5ffc5-4677-4264-a246-8def4418505a)

- Implement disconnected edges and edge interactions (#7864).
- Port edge layout from Rust.
- Implement output ports, hover extensions, backward-edge arrows, hover-splitting.

# Important Notes
- A new `currentInteraction` API supports mutually-exclusive interactions; this is used to cancel edge creation when the CB is opened. We can use it more generally to ensure only one major interaction is ongoing at a time.
- Remaining details to reach parity with gui1 edges: #8139
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Oct 25, 2023
@farmaazon farmaazon mentioned this issue Oct 30, 2023
Closed
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edge interactions and rendering enso-org/enso
2 participants
@kazcw @farmaazon