Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview visualization in Component Browser #7787

Closed
Tracked by #7685
farmaazon opened this issue Sep 11, 2023 · 3 comments
Closed
Tracked by #7685

Preview visualization in Component Browser #7787

farmaazon opened this issue Sep 11, 2023 · 3 comments
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Sep 11, 2023

The Component Browser should show a visualization preview of the current input expression if no suggestion is selected, or an expression being created after applying by the suggestion if selected.

The first approach should be to check if we can just create a visualization with the expression being a searcher input (and then the usual preprocessor). Check if the engine has sufficient support.

@farmaazon farmaazon mentioned this issue Sep 11, 2023
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint -gui labels Sep 11, 2023
@farmaazon farmaazon added p-medium Should be completed in the next few sprints and removed p-high Should be completed in the next sprint labels Sep 25, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Oct 16, 2023
@farmaazon farmaazon self-assigned this Oct 16, 2023
@farmaazon farmaazon moved this from 📤 Backlog to ⚙️ Design in Issues Board Oct 17, 2023
@farmaazon farmaazon moved this from ⚙️ Design to 🔧 Implementation in Issues Board Nov 17, 2023
@enso-bot
Copy link

enso-bot bot commented Nov 20, 2023

Adam Obuchowicz reports a new STANDUP for the last Friday (2023-11-17):

Progress: Look what changes are required for using existing vis view in Component Browser. Started adding new methods to lsRPC and ExecutionContext class. It should be finished by 2023-11-24.

Next Day: Next day I will be working on the same task. Continue working. Do refactoring needed in the view.

@farmaazon
Copy link
Contributor Author

farmaazon commented Dec 7, 2023

Initial implementation merged, but we still needs to resolve problem described in https://github.com/orgs/enso-org/discussions/6832#discussioncomment-7754474

GitHub
Currently, the data for dynamic node widgets is requested using language server's Visualization API. That allows us to resolve method annotations using the data from evaluated method call's target....

@farmaazon farmaazon moved this from 🔧 Implementation to 📤 Backlog in Issues Board Dec 7, 2023
@farmaazon
Copy link
Contributor Author

Tested on today's engine and it seems working (except changing visualization type).

@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Dec 18, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

No branches or pull requests

1 participant