Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization Container with chooser, resizing etc. #7733

Closed
Tracked by #7685
farmaazon opened this issue Sep 5, 2023 · 14 comments · Fixed by #7773
Closed
Tracked by #7685

Visualization Container with chooser, resizing etc. #7733

farmaazon opened this issue Sep 5, 2023 · 14 comments · Fixed by #7773
Assignees
Labels
-gui p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Sep 5, 2023

As in the new design

Image

The visualizations are Vue components.

The two first icons (eye and "compass") are managed by the node view (this is "show/hide visualization" and "visualization chooser" respectively), others are parts of the visualization.

The visualization themselves needs to use "VisualizationLayout" component provided by us, which will allow using multiple predefined slots for putting different UI elements (for example a button bar) in the right place.

@farmaazon farmaazon mentioned this issue Sep 5, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Sep 5, 2023
@farmaazon farmaazon added s-info-needed Status: more information needed from submitter p-high Should be completed in the next sprint -gui labels Sep 5, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Sep 5, 2023
@farmaazon farmaazon removed the s-info-needed Status: more information needed from submitter label Sep 5, 2023
@enso-bot
Copy link

enso-bot bot commented Sep 5, 2023

E-Hern Lee reports a new STANDUP for the provided date (2023-09-04):

Progress: - port some visualizations to vue

  • read up on visualization design, and docs for old API
  • implement circular menu and toolbars It should be finished by 2023-09-12.

@somebody1234
Copy link
Contributor

E-Hern Lee reports a new STANDUP for the provided date (2023-09-04):

Progress: - begin integrating visualizations into GraphNode to ensure they actually work

  • refactor visualizations into their own module
    • this is mainly to dogfood (and help develop) the infrastructure to dynamically load modules
      • (note that this does not currently work. we probably need to import vue/compiler-sfc, and potentially also a VFS to combine the builtin visualizations with the project-local visualizations into the same file tree for compilation purposes)
  • change visualization component's API to use slots (default slot for main content, and toolbar slot for the (single) component-specific toolbar)
  • minor changes to CSS. ⚠️ the circular menu and toolbars now use a background-filter: blur(64px), according to the figma design. it has been brought up that this is potentially computationally expensive, so we should consider adding an option to disable all blurs (and potentially all transparency too) across the entire app

other issues -

  • fix merge conflicts, tidy up code, add dummy actions, and open PR (7726) for top bar (7730)
  • fix merge conflicts, tidy up code, and open PR (7728) for widgets (7731)

(:information_source: note: posting standup manually because the bot errored - the standup appears as expected on airtable.)

@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board Sep 6, 2023
@enso-bot
Copy link

enso-bot bot commented Sep 6, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-09-06):

Progress: implement fullscreen
make visualization ref type-safe in GraphNode
add width/height/fullscreen props to Visualization

other issues -
address reviews for widgets PR It should be finished by 2023-09-12.

Next Day: resizing, registering visualizations, UI (and logic?) for visualization switcher

@enso-bot
Copy link

enso-bot bot commented Sep 7, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-09-07):

Progress: - use :="$attrs" to avoid having to explicitly pass though every prop from VisualizationContainer to GraphNode

  • registering visualizations
  • add default for image
  • visualization switcher

other issues -

  • address review for top bar PR It should be finished by 2023-09-12.

Next Day: resizing, investigate (and/or implement) script/style dependencies - handled by loadScript and loadStyle in the old impl

@somebody1234 somebody1234 mentioned this issue Sep 8, 2023
5 tasks
@enso-bot
Copy link

enso-bot bot commented Sep 8, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-09-08):

Progress: - script/style dependencies (handled by native url imports)

  • finish scatterplot visualization
  • begin geo map visualization
  • add simple visualizations (error, json)
  • various fixes It should be finished by 2023-09-12.

Next Day: resizing, finish geo map visualization?

@enso-bot
Copy link

enso-bot bot commented Sep 11, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-09-11):

Progress: - (saturday) get vue -> js working

  • the builtin visualizations use the same mechanism.
    • this is partly to make sure that it works
    • but also so that the files used by the builtin visualizations will ideally be available to users too
  • finish porting geomap visualization
  • port table visualization It should be finished by 2023-09-12.

Next Day: fixes, resizing???! (probably needs useComputed* to calculate dimensions based on props), heatmap and sql visualizations still need to be ported

@enso-bot
Copy link

enso-bot bot commented Sep 12, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-09-12):

Progress: - add resizing

  • add sql visualization
  • add heatmap visualization
  • bugfixes It should be finished by 2023-09-12.

@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Sep 13, 2023
@enso-bot
Copy link

enso-bot bot commented Sep 13, 2023

E-Hern Lee reports a new 🔴 DELAY for the provided date (2023-08-13):

Summary: There is 6 days delay in implementation of the Visualization Container with chooser, resizing etc. (#7733) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: increase in scope? (ended up porting all visualizations)

@enso-bot
Copy link

enso-bot bot commented Sep 13, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-09-13):

Progress: finish heatmap visualization
test all visualizations and fix bugs It should be finished by 2023-09-18.

@enso-bot
Copy link

enso-bot bot commented Sep 15, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-09-15):

Progress: - attempt to merge with language server + binary protocol

  • partially address review It should be finished by 2023-09-18.

@enso-bot
Copy link

enso-bot bot commented Sep 19, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-09-18):

Progress: - implement histogram visualization

  • begin addressing d3 review issue It should be finished by 2023-09-18.

@enso-bot
Copy link

enso-bot bot commented Sep 19, 2023

E-Hern Lee reports a new 🔴 DELAY for yesterday (2023-09-19):

Summary: There is 4 days delay in implementation of the Visualization Container with chooser, resizing etc. (#7733) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: addressing code review

@enso-bot
Copy link

enso-bot bot commented Sep 19, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-09-19):

Progress: refactors (+ bugfixes) to address d3 review It should be finished by 2023-09-22.

@farmaazon farmaazon added p-medium Should be completed in the next few sprints and removed p-high Should be completed in the next sprint labels Sep 21, 2023
@enso-bot
Copy link

enso-bot bot commented Sep 22, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-09-22):

Progress: - address reviews

  • debug and fix issue with reactivity (method calls don't trigger reactive updates)

other issues -

  • begin integrating shortcut manager with gui
  • clean up binary protocol PR It should be finished by 2023-09-22.

@mergify mergify bot closed this as completed in #7773 Sep 26, 2023
mergify bot pushed a commit that referenced this issue Sep 26, 2023
- Closes #7733
- Add infrastructure for defining custom visualizations
- Add all visualizations

# Important Notes
:warning: Changes made:
- "Fit all" has been changed to always animate - this is because behavior was previously inconsistent:
- the scatterplot would always animate on "Fit all", but
- the histogram would never animate on "Fit all"
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Sep 26, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants