Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the Widget set up for Public APIs and Improve Stuff (May) #6410

Closed
23 tasks done
jdunkerley opened this issue Apr 25, 2023 · 25 comments
Closed
23 tasks done

Review the Widget set up for Public APIs and Improve Stuff (May) #6410

jdunkerley opened this issue Apr 25, 2023 · 25 comments
Assignees
@radeusgd @jdunkerley @GregoryTravis
Labels
-libs Libraries: New libraries to be implemented
Milestone
Beta Release

Comments

@jdunkerley
Copy link
Member

jdunkerley commented Apr 25, 2023 •
edited
Loading

Task list of little things:

  • SQLite_Format.For_File should fail early if the file is not a SQLite DB. Include checking an empty file. [@radeusgd]
  • Data.read should error if the file does not exist (for all file types). [@radeusgd]
  • Update defaults on Table.join (Inner->Left_Outer, join by first column name instead of index) [@radeusgd]
  • Remove the _ from the join right_prefix and also from NameDeduplicator [@radeusgd]
  • Date_Range type and support for up_to / down_to on Date. Range.Between not working with Dates #6543
  • tokenize_to_columns or parse_to_columns results in a single column we shouldn't add the 1. [@GregoryTravis]
  • Add tests for Date.until, Date.next and Date.previous. [@GregoryTravis]
  • Row count status line on Table viz is really annoying [@jdunkerley]
  • Table visualization of a function should be <Function> not {Error object}. [@jdunkerley]
  • Render null in Table viz as light grey null. [@jdunkerley]
  • Rendering of the Vector of weekday versus Table of weekday in Table viz [@jdunkerley]
  • Row .get doesn't have a drop down or Table vis. [@jdunkerley]
  • Experiment with delimiter drop down. [@jdunkerley]
  • Add delimiter dropdown to split functions. [@jdunkerley]
  • rename_columns to allow a Vector of Pairs (should error if mixed) and have a widget to design [@jdunkerley]
  • Refresh the dropdown set up on Table. [@jdunkerley]
  • Custom dropdown for take and drop on Text. [@radeusgd]
  • take/drop defaults for Sample and Every. Additionally should report error more gracefully for constructor of valid type. [@radeusgd]
  • Add drop down for Locale like Encoding. [@GregoryTravis]
  • Look at set vs add_column / update_column. Add ALIASes. [@jdunkerley]
  • .tables on a connection does not accept a single value for Sqlite (e.g. 'TABLE') - dropdown supplies single values! [@jdunkerley]
  • Add decode methods to HTTP Response and Body allowing easier parsing. [@jdunkerley]
  • Remove the custom filter drop down as not needed any more. [@jdunkerley]

** Others moved to June. **
@jdunkerley jdunkerley added the -libs Libraries: New libraries to be implemented label Apr 25, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone Apr 25, 2023
@jdunkerley jdunkerley self-assigned this Apr 25, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Apr 25, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 2, 2023
@jdunkerley jdunkerley changed the title Review the Widget set up for Public APIs Review the Widget set up for Public APIs and Improve Stuff (May) May 5, 2023
@jdunkerley
Copy link
Member Author

On auto Date Parsing from @radeusgd:

I think one thing I'd really like to see here is to ensure we don't confuse dd-mm-yyyy with mm-dd-yyyy - so if from the data it cannot be conclusively inferred*, we should at least produce a warning about it or maybe even error? because it's quite a possible data corruption

*we can infer it if we have entries like 12-30-2022 because the 30 cannot ever be a month

@radeusgd radeusgd mentioned this issue May 8, 2023
Merged
5 tasks
mergify bot pushed a commit that referenced this issue May 9, 2023
@radeusgd
Improve Non_Unique_Primary_Key error, split file format detection i…
d8b9269 
…nto read/write, improve SQLite format detection (#6604)

Closes #6437
Related to #6410

- Add example duplicate row to `Non_Unique_Primary_Key`.
- Ensure `File.read` fails if the file does not exist, always.
- Ensure SQLite fails if file is empty or nonexistent or malformed.
- Split file format detection into read and write modes, so that the read mode can depend on actual file _contents_.
@enso-bot
Copy link

enso-bot bot commented May 10, 2023

James Dunkerley reports a new STANDUP for today (2023-05-10):

Progress: Some grid work but mostly IDE testing and QA. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. More bugs!

@radeusgd radeusgd mentioned this issue May 10, 2023
Merged
5 tasks
@enso-bot enso-bot bot mentioned this issue May 10, 2023
Closed
2 tasks
@radeusgd
Copy link
Member

radeusgd commented May 11, 2023 •
edited by unfurl-links bot
Loading

The https://github.com/tsegall/fta library may be worth looking at for Date parsing - it provides pretty neat date format detection.

GitHub
Metadata/data identification Java library. Identifies Semantic Type information (e.g. Gender, Age, Color, Country,...). Extensive country/language support. Extensible via user-defined plugins. Comp...

@enso-bot
Copy link

enso-bot bot commented May 11, 2023

James Dunkerley reports a new STANDUP for today (2023-05-11):

Progress: Lots of work on the Table viz. Some ordering of the little tickets with libs team. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. More bugs!

@enso-bot
Copy link

enso-bot bot commented May 11, 2023

Greg Travis reports a new STANDUP for today (2023-05-11):

Progress: Locale drop-down for column and dates It should be finished by 2023-05-31.

Next Day: more probably

@enso-bot
Copy link

enso-bot bot commented May 12, 2023

Radosław Waśko reports a new STANDUP for yesterday (2023-05-11):

Progress: Applied review comments and got the Date_Range PR merged. Work on take/drop widgets - changed approach a bit, improved the error handling. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the same task. Prepare a PR for take/drop widgets.Start work on row number function.

@enso-bot
Copy link

enso-bot bot commented May 12, 2023

Radosław Waśko reports a new STANDUP for today (2023-05-12):

Progress: Fixing and testing the take/drop widgets. Hunting bugs along the way (State disappearing inside Vector.map; quotes breaking Widget parser in IDE). Got the PR ready to merge. Reviews and bookclub. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6112 task. Implement cast for in memory and finish the prototype for Database.

mergify bot pushed a commit that referenced this issue May 12, 2023
@radeusgd
Improving widgets for take/drop (#6641)
f5071a1 
Related to #6410

# Important Notes
- Updated some `Meta` methods (needed for error handling):
- `Meta.Type` now has `name` and `qualified_name`.
- `Meta.Constructor` has `declaring_type` allowing to get the type that this constructor is associated with.
@enso-bot
Copy link

enso-bot bot commented May 12, 2023

James Dunkerley reports a new STANDUP for today (2023-05-12):

Progress: Lots of QA with Sylwia. Got the table tweaks merged. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. More bugs!

@enso-bot
Copy link

enso-bot bot commented May 12, 2023

Greg Travis reports a new STANDUP for today (2023-05-12):

Progress: Locale dropdown on static methods; also rounding It should be finished by 2023-05-31.

Next Day: same

@unfurl-links unfurl-links bot mentioned this issue May 16, 2023
Closed
@enso-bot
Copy link

enso-bot bot commented May 16, 2023

James Dunkerley reports a new STANDUP for today (2023-05-16):

Progress: Some QA and catch up. Planning. Some bugs and investigating why a dropdown didnt show. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. More bugs!

@enso-bot
Copy link

enso-bot bot commented May 17, 2023

James Dunkerley reports a new STANDUP for today (2023-05-17):

Progress: Sort out Row rendering in the table viz and some minor fixes for table viz. Adding shortcuts for using Vector and Range as columns. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. S3 reading and some more bugs.

@enso-bot
Copy link

enso-bot bot commented May 18, 2023

James Dunkerley reports a new STANDUP for today (2023-05-18):

Progress: PRs, some QA and Book Club testing. Mostly widget configuration and testing. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. S3 reading and some more bugs.

@enso-bot
Copy link

enso-bot bot commented May 19, 2023

James Dunkerley reports a new STANDUP for today (2023-05-19):

Progress: Some more bug triaging - identified as double clicking issue. Adding and refining all the dropdowns on table. Design session with Ned and Sylwia. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. Some more minor issues, running stats on table with grouping, separate By_Name and Blank_Columns.

@enso-bot enso-bot bot mentioned this issue May 19, 2023
Closed
7 tasks
@enso-bot
Copy link

enso-bot bot commented May 19, 2023

Radosław Waśko reports a new STANDUP for yesterday (2023-05-19):

Progress: Prepared parse PR. Some work on bookclubs. Reviews. Started work on Mixed casts - design and first steps. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. Finish Mixed casts.

@enso-bot
Copy link

enso-bot bot commented May 22, 2023

James Dunkerley reports a new STANDUP for today (2023-05-22):

Progress: Some work on execution context control for Table.Write. Some unit tests for the new functions added. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. More testing and hopefully join drop down!

@enso-bot
Copy link

enso-bot bot commented May 23, 2023

James Dunkerley reports a new STANDUP for today (2023-05-23):

Progress: Some planning of the backend teams. An interview. Trying to work through parsing a flat file. Book club and some drop down fixes. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. More testing and hopefully join drop down!

@enso-bot
Copy link

enso-bot bot commented May 24, 2023

James Dunkerley reports a new STANDUP for today (2023-05-24):

Progress: Table.write now working with exec context. Some more testing and fixes. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. More testing and hopefully join drop down!

@enso-bot enso-bot bot mentioned this issue May 25, 2023
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented May 25, 2023

James Dunkerley reports a new STANDUP for today (2023-05-25):

Progress: Going through Greg's issues and reviewing with Sylwia. Working through a book club idea and seeing all the warts. Some funeral admin so less time than usual. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. More testing...

@radeusgd
Copy link
Member

As noted on Discord, Vector.new_builder is currently not hidden in the GUI. But such stateful computations are unusable in the GUI mode. Shall we hide it by adding PRIVATE ADVANCED?

@radeusgd radeusgd mentioned this issue May 25, 2023
Closed
@enso-bot
Copy link

enso-bot bot commented May 25, 2023

Radosław Waśko reports a new STANDUP for today (2023-05-25):

Progress: Adding better error handling to Mixed types. Reviews. Catching up on bookclubs, lots of issue reporting. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6860 task. Start work on add_row_numbers. Catch up on remaining bookclubs if time allows.

@enso-bot
Copy link

enso-bot bot commented May 31, 2023

James Dunkerley reports a new STANDUP for yesterday (2023-05-30):

Progress: Fixed Regex issue. Improving web response parsing. PR reviewing. Planning. Demo. QA. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. More testing...

@radeusgd
Copy link
Member

re: inexhaustive pattern match better errors

We should be able to just adapt the solution take/drop uses:
image

The method is already rather re-usable, just need to replace range in the error message with sth generated from expected types.

@enso-bot
Copy link

enso-bot bot commented May 31, 2023

James Dunkerley reports a new STANDUP for yesterday (2023-05-30):

Progress: Updated the dropdown code for the new spec. Added decode methods to Response. Regex issue again 😦 Meetings. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. Get PR merged.

@enso-bot
Copy link

enso-bot bot commented Jun 1, 2023

James Dunkerley reports a new STANDUP for the provided date (2023-05-26):

Progress: Tracing through the Regex issue. Reviewing PRs. Interview. Some fixes. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. More testing...

@enso-bot
Copy link

enso-bot bot commented Jun 1, 2023

James Dunkerley reports a new STANDUP for yesterday (2023-05-31):

Progress: Updated the dropdown code for the new spec. Added decode methods to Response. Regex issue again 😦 Meetings. It should be finished by 2023-05-31.

Next Day: Next day I will be working on the #6410 task. Get PR merged.

@jdunkerley jdunkerley moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radeusgd radeusgd

@jdunkerley jdunkerley

@GregoryTravis GregoryTravis

Labels
-libs Libraries: New libraries to be implemented
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

No branches or pull requests
3 participants
@radeusgd @jdunkerley @GregoryTravis