Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play button support #5179

Closed
wdanilo opened this issue Feb 5, 2023 · 5 comments
Closed

Play button support #5179

wdanilo opened this issue Feb 5, 2023 · 5 comments
Assignees
Labels
-compiler -syntax p-low Low priority x-new-feature Type: new feature request

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by jaroslavtulach.
Original issue is here.


Blocks: https://www.pivotaltracker.com/story/show/182746085
The play button will be part of IO control system - e.g. #182781696

This may heavily involve the controller in GUI. On the top of the GUI there will be a button allowing switching the mode (production <-> development <-> maybe other modes). Given a mode, every IO node is assigned with info if it should auto-refresh. In the production mode all IO nodes are refreshed by default. In development mode, all IO nodes are not refreshed by default and the user needs to press play button next to the nodes. Unfortunately, this is important and we constantly hear about it from people. E.g. you open your dataflow network and you want to change it, but you dont want to override your database when playing with values. So you switch to dev mode and nothing evaluates until you want to. Also, the nodes should not evaluate their IO actions even if visualizations are opened. Anyway, this requires a bigger talk with the engine team, because support for it seems non-trivial. In particular, if the IO operations are nested, e.g. after collapsing a node, we still want to have the "play button" visible on the collapsed node and we want the inner IO nodes to not autorefresh in the given mode. This can't be done by GUI, as after the definition of the collapsed node changes, things should be updated and work. Let's have a talk about how much of that can be done and when.

Blockers:

#182781696 blocked

@jdunkerley
Copy link
Member

@sylwiabr and @jdunkerley to discuss what parts of this need moving forward.

@jdunkerley jdunkerley moved this to ⚙️ Design in Issues Board Feb 14, 2023
@jdunkerley
Copy link
Member

Following #5713 will replace with new tickets.

@jdunkerley jdunkerley closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2023
@github-project-automation github-project-automation bot moved this from ⚙️ Design to 🟢 Accepted in Issues Board Mar 14, 2023
@wdanilo
Copy link
Member Author

wdanilo commented Mar 15, 2023

@jdunkerley Ive just noticed that the design doc does NOT mention the play button. Basically, in "development" mode we should have play button which pressed should just override the context to "production" for a second, run all nodes, and switch back to development. This allows for "one-shot" execution of the graph. I think this is an important thing, and pretty easily implementable probably. It's also already designed in Figma (see below). Do you agree?

image

@wdanilo wdanilo reopened this Mar 15, 2023
@wdanilo
Copy link
Member Author

wdanilo commented Mar 15, 2023

Reopening because of the question above ^^^

@jdunkerley
Copy link
Member

Good point - I'll add a section to the document covering this.

@jdunkerley jdunkerley moved this from ❓New to 🔧 Implementation in Issues Board Mar 15, 2023
@jdunkerley jdunkerley moved this from 🔧 Implementation to 👁️ Code review in Issues Board Mar 20, 2023
@jdunkerley jdunkerley moved this from 👁️ Code review to 🔴 Changes requested in Issues Board Mar 21, 2023
@jdunkerley jdunkerley moved this from 🔴 Changes requested to 👁️ Code review in Issues Board Mar 24, 2023
@jdunkerley jdunkerley assigned wdanilo and unassigned jdunkerley Mar 24, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 25, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler -syntax p-low Low priority x-new-feature Type: new feature request
Projects
Archived in project
Development

No branches or pull requests

5 participants