-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play button support #5179
Comments
@sylwiabr and @jdunkerley to discuss what parts of this need moving forward. |
Following #5713 will replace with new tickets. |
@jdunkerley Ive just noticed that the design doc does NOT mention the play button. Basically, in "development" mode we should have play button which pressed should just override the context to "production" for a second, run all nodes, and switch back to development. This allows for "one-shot" execution of the graph. I think this is an important thing, and pretty easily implementable probably. It's also already designed in Figma (see below). Do you agree? |
Reopening because of the question above ^^^ |
Good point - I'll add a section to the document covering this. |
This task is automatically imported from the old Task Issue Board and it was originally created by jaroslavtulach.
Original issue is here.
Blocks: https://www.pivotaltracker.com/story/show/182746085
The play button will be part of IO control system - e.g. #182781696
This may heavily involve the controller in GUI. On the top of the GUI there will be a button allowing switching the mode (production <-> development <-> maybe other modes). Given a mode, every IO node is assigned with info if it should auto-refresh. In the production mode all IO nodes are refreshed by default. In development mode, all IO nodes are not refreshed by default and the user needs to press play button next to the nodes. Unfortunately, this is important and we constantly hear about it from people. E.g. you open your dataflow network and you want to change it, but you dont want to override your database when playing with values. So you switch to dev mode and nothing evaluates until you want to. Also, the nodes should not evaluate their IO actions even if visualizations are opened. Anyway, this requires a bigger talk with the engine team, because support for it seems non-trivial. In particular, if the IO operations are nested, e.g. after collapsing a node, we still want to have the "play button" visible on the collapsed node and we want the inner IO nodes to not autorefresh in the given mode. This can't be done by GUI, as after the definition of the collapsed node changes, things should be updated and work. Let's have a talk about how much of that can be done and when.
Blockers:
#182781696 blocked
The text was updated successfully, but these errors were encountered: