Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire the Text_Matcher and Regex_Matcher and update the column selectors. #5124

Closed
wdanilo opened this issue Feb 5, 2023 · 3 comments · Fixed by #5719
Closed

Retire the Text_Matcher and Regex_Matcher and update the column selectors. #5124

wdanilo opened this issue Feb 5, 2023 · 3 comments · Fixed by #5719
Assignees
Labels
-libs Libraries: New libraries to be implemented l-regex p-low Low priority x-new-feature Type: new feature request

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by James Dunkerley.
Original issue is here.


type Column_Selector
    ## Selects columns based on their names.

      - names: Set of names to match.
      - case_sensitivity: Specifies whether the matching should be case sensitive.
      - use_regex: Allow regular expression based patterns.
    By_Name (names : Vector Text) (case_sensitivity:Case_Sensitivity=Case_Sensitivity.Sensitive) use_regex=Boolean=False

    ## Selects columns by their index.

       - indexes: Set of indexes to match.
         The index of the first column in the table is 0. 
         If the provided index is negative, it counts from the end of the table
         (e.g. -1 refers to the last column in the table).
    By_Index (indexes : Vector Integer)

This also removes support for selecting by column. This only worked by matching on name in a case sensitive way (not on the specific column instance). The other uses become:

type Column_Name_Mapping
    ## Selects columns based on their names.

      - names: Map of old names to find with replacements.
        If use regular expression, the special replace patterns can be used.
      - case_sensitivity: Specifies whether the matching should be case sensitive.
      - use_regex: Allow regular expression based patterns.
    By_Name (names : Map Text Text) (case_sensitivity:Case_Sensitivity=Case_Sensitivity.Sensitive) use_regex:Boolean=False

    ## Selects columns by their index.       

      - indexes: Map of indexes with the new name.
        The index of the first column in the table is 0. If the provided index is
        negative, it counts from the end of the table (e.g. -1 refers to the last
        column in the table).
    By_Index (indexes : Map Integer Text)

    ## Selects columns by position starting at the first column until the
       new_names is exhausted.
    By_Position (new_names : [Text])
@wdanilo wdanilo added this to the Beta Release milestone Feb 6, 2023
@jdunkerley jdunkerley moved this to 📤 Backlog in Issues Board Feb 6, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to 🔧 Implementation in Issues Board Feb 20, 2023
@jdunkerley
Copy link
Member

Covered Column_Selector by #5646, still to work on Column_Name_Mapping.

@enso-bot
Copy link

enso-bot bot commented Feb 20, 2023

James Dunkerley reports a new STANDUP for today (2023-02-20):

Progress: Fixed the viz for 2D vectors. Removed the Column_Name_Mapping type and am restructuring the rename_columns. It should be finished by 2023-02-21.

Next Day: Finish rename columns, backlog tidy and iteration assignments. Hopefully DB/InMemory alignment checks

@jdunkerley jdunkerley moved this from 🔧 Implementation to 👁️ Code review in Issues Board Feb 21, 2023
@enso-bot
Copy link

enso-bot bot commented Feb 21, 2023

James Dunkerley reports a new STANDUP for today (2023-02-21):

Progress: Finished the rename_columns work. Added first_row, second_row and last_row to the Table. Sorted the backlog into milestones and tidied up a lot. It should be finished by 2023-02-21.

Next Day: Next day I will be working on the #5713 task. Design for the MVP for writing data to files and the database.

@mergify mergify bot closed this as completed in #5719 Feb 23, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented l-regex p-low Low priority x-new-feature Type: new feature request
Projects
Archived in project
3 participants