-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate Vector & Array #5011
Comments
Jaroslav Tulach reports a new STANDUP for yesterday (2023-04-06): Progress: - Consolidate Array and Vector: #6218
Next Day: Easter vacation |
Fixes #5011 by making sure the same methods that are on `Vector` are also available on `Array`.
Jaroslav Tulach reports a new STANDUP for yesterday (2023-04-11): Progress: - Array&Vector PR merged: #6218
Next Day: 5x slower if cascade
|
This task is automatically imported from the old Task Issue Board and it was originally created by jaroslavtulach.
Original issue is here.
#183000876 has removed the difference between Enso
Array
&Vector
- they both "duck like a polyglot array". The only difference is thatVector
originates from Enso and is idealized as immutable.Array
comes from Java, JavaScript, Python, etc. and nobody knows much about it.The next step is to consolidate them more:
Vector
andArray
shall be the same (as much as possible)Vector.to_array
,Vector.unsafe_at
Vector.from_polyglot_array
method shall be renamed - see discussionTasks:
Vector
andArray
typeVector
and polyglot array can be used interchangeably when calling builtinsDeferred Tasks
Vector.to_array
)Vector.from_polyglot_array
at
instead ofunsafe_at
and if fine, removeunsafe_at
Vector
- like (Vector.from_array arr) . mapBlockers:
#183000876 resolved
#183266964 resolved
#183058716 resolved
#184278959 resolved
Comments:
To consolidate Vector & Array we want to make sure both
Vector
andArray
can be used interchangeably. That's not currently the case. There are two known problems where explicit convertsionto_array
is still required:I am afraid we have to address these two sample needless conversions in builtins before we can claim a victory in consolidating Vector & Array.
(jaroslavtulach - Sep 29, 2022)
**Hubert Plociniczak** reports a new **STANDUP** for yesterday (2023-01-09):
Progress: QA, trying to work on consolidation but little work done due to other distractions. Investigated double reporting of errors as noticed by Radek (will report the ticket once I have something tangible). It should be finished by 2023-01-12.
Next Day: Next day I will be working on the #183217534 task. More QA and consolidation work. (Enso Bot - Jan 10, 2023)
**Hubert Plociniczak** reports a new **STANDUP** for yesterday (2023-01-11):
Progress: QA, problems with Windows setup to reproduce vcs issues. Minor tweaks to consolidation work (decided to postpone until James' work on API improvements lands. It should be finished by 2023-01-12.
Next Day: Next day I will be working on the #183217534 task. Look into resolving fully qualified names, pick up vector/array work. (Enso Bot - Jan 12, 2023)
The text was updated successfully, but these errors were encountered: