Renaming a project causes collapsed function added by Component Browser to stop working #11815
Comments
|
Refinement notes:
|
|
Keziah Wesley reports a new STANDUP for yesterday (2024-12-16): Progress: Refactoring qualified names in suggestion DB to be independent of project QN. It should be finished by 2024-12-20. Next Day: Next day I will be working on the #11815 task. Finish, start next task. |
|
Keziah Wesley reports a new STANDUP for yesterday (2024-12-17): Progress: Refactoring suggestion DB / CB to use parsed QNs. It should be finished by 2024-12-20. Next Day: Next day I will be working on the #11815 task. Finish, start next task. |
|
Keziah Wesley reports a new STANDUP for yesterday (2024-12-18): Progress: Still refactoring suggestion DB. It should be finished by 2024-12-20. Next Day: Next day I will be working on the #11815 task. Finish, start next task. |
- `SuggestionUpdateProcessor` will simplify adding more contextual information to the update application process. - Mock suggestion data is constructed using `lsUpdate` so that the mocking logic doesn't have to be kept consistent with the `lsUpdate` implementation. - When uploading, use `ExternalId` to identify function; it's simpler than comparing stack items. - Correct some language server definitions that can be `null` in practice. - Add a test covering *current* behavior wrt. #11815; following PR will update expected results.
|
Keziah Wesley reports a new STANDUP for yesterday (2024-12-19): Progress: Split out some preparatory refactoring and PR'd. It should be finished by 2024-12-20. Next Day: Next day I will be working on the #11815 task. Finish, start next task. |
|
Keziah Wesley reports a new STANDUP for the last Friday (2024-12-20): Progress: Didn't end up getting much work done today It should be finished by 2024-12-20. Next Day: Next day I will be working on the #11815 task. Finish, start next task. |
* Refactoring in preparation for normalized qualified names - `SuggestionUpdateProcessor` will simplify adding more contextual information to the update application process. - Mock suggestion data is constructed using `lsUpdate` so that the mocking logic doesn't have to be kept consistent with the `lsUpdate` implementation. - When uploading, use `ExternalId` to identify function; it's simpler than comparing stack items. - Correct some language server definitions that can be `null` in practice. - Add a test covering *current* behavior wrt. #11815; following PR will update expected results.
|
Keziah Wesley reports a new STANDUP for yesterday (2025-01-02): Progress: Normalizing the suggestion DB data model; not strictly needed for this task but we have upcoming SDB changes that will benefit from it too. It should be finished by 2025-01-09. Next Day: Next day I will be working on the #11815 task. Same task. |
|
Keziah Wesley reports a new STANDUP for the last Friday (2025-01-03): Progress: Refactored suggestion DB to properly represent suggestion-type-specific data. It should be finished by 2025-01-09. Next Day: Next day I will be working on the #11815 task. Now that the structure is in place, simplify how the LS data is mapped to the data we need. |
|
Keziah Wesley reports a new STANDUP for yesterday (2025-01-06): Progress: Refactored mapping of LS data to app data. It should be finished by 2025-01-09. Next Day: Next day I will be working on the #11815 task. Updating tests, integrating earlier QN WIP with structure refactor. |
|
Keziah Wesley reports a new STANDUP for the last Tuesday (2025-01-07): Progress: Update lsUpdate tests, working on the various smaller tests. It should be finished by 2025-01-09. Next Day: Next day I will be working on the #11815 task. Finishing |
|
Keziah Wesley reports a new STANDUP for yesterday (2025-01-08): Progress: Generalizing types to allow items in top level of module It should be finished by 2025-01-09. Next Day: Next day I will be working on the #11815 task. Finishing |
|
Keziah Wesley reports a new STANDUP for yesterday (2025-01-09): Progress: Working through test failures It should be finished by 2025-01-09. Next Day: Next day I will be working on the #11815 task. Finishing |
|
Keziah Wesley reports a new STANDUP for the last Friday (2025-01-10): Progress: Propagating type changes through computed values store / message pointers to the process boundary. It should be finished by 2025-01-18. Next Day: Next day I will be working on the #11815 task. Finishing PR |
|
Keziah Wesley reports a new STANDUP for yesterday (2025-01-13): Progress: Working on CV store, imports analysis changes It should be finished by 2025-01-18. Next Day: Next day I will be working on the #11815 task. Finishing PR |
|
Keziah Wesley reports a new STANDUP for yesterday (2025-01-14): Progress: Switching usages of LS types to parallel hierarchy of types with our normalizations It should be finished by 2025-01-18. Next Day: Next day I will be working on the #11815 task. Finishing PR |
|
Keziah Wesley reports a new STANDUP for yesterday (2025-01-15): Progress: Switching usages of LS types to parallel hierarchy of types with our normalizations; opened a PR covering SDB refactor It should be finished by 2025-01-18. Next Day: Next day I will be working on the #11815 task. Finishing task |
Allow different suggestion DB types to have different properties, instead of assigning placeholder values; move type-specific entry logic into entry definitions. The `Any` type is now implicit: It is no longer stored as a parent of every type. When filtering by self-type, `Any` is treated as unknown. Part of #11815.
|
Keziah Wesley reports a new STANDUP for yesterday (2025-01-16): Progress: Switching to normalized types It should be finished by 2025-01-18. Next Day: Next day I will be working on the #11815 task. Final PR of task |
See the video below:
Enso_i3Qapeb7xo.mp4
The issue stems from the fact that while the effect of
Ctrl-GisMain.collapsed, once I add a new instance from Component Browser is notMain.<name>butProjectName.<name>. Thus, once the project gets renamed, the reference is no longer valid.We should either:
Main.<name>or just<name>for the local symbol, so its name is not tied with the current project.The text was updated successfully, but these errors were encountered: