Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Editor Look&Feel - Copy components in the menu. #11634

Closed
Tracked by #11510
farmaazon opened this issue Nov 22, 2024 · 0 comments · Fixed by #11690
Closed
Tracked by #11510

Graph Editor Look&Feel - Copy components in the menu. #11634

farmaazon opened this issue Nov 22, 2024 · 0 comments · Fixed by #11690
Assignees
Labels

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Nov 22, 2024

The action should just copy selected components: as we always select the node where menu was opened (both by three-dots menu and right-click), it should be still intuitive.

@farmaazon farmaazon changed the title Copy component(s) in the menu. - selected components. - (1) Graph Editor Look&Feel - Copy components in the menu. Nov 22, 2024
@farmaazon farmaazon added the -gui label Nov 22, 2024
@farmaazon farmaazon added this to the 2024-12 Release milestone Nov 22, 2024
@kazcw kazcw self-assigned this Nov 22, 2024
@kazcw kazcw linked a pull request Nov 29, 2024 that will close this issue
5 tasks
@kazcw kazcw moved this from ❓New to 👁️ Code review in Issues Board Nov 29, 2024
@mergify mergify bot closed this as completed in #11690 Nov 29, 2024
mergify bot pushed a commit that referenced this issue Nov 29, 2024
Context menu, copy button, multi-component actions

https://github.com/user-attachments/assets/14243102-3848-43fc-82bb-a48648536985

- The 'More' menu can now be opened under the mouse, through the context menu action (right click/control-click on Mac/menu button on keyboard).
- Add copy-components button to menu.
- The menu can now be opened while multiple components are selected; if the clicked component was among the selected components, the selection will be preserved. Some menu actions--currently *copy* and *delete*, apply to all selected components. These actions will change their displayed labels when multiple components are selected. If a single-component action is executed, the component it was applied to will become the sole selection.

Fixes #11633, #11634
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Nov 29, 2024
jdunkerley pushed a commit that referenced this issue Nov 29, 2024
Context menu, copy button, multi-component actions

https://github.com/user-attachments/assets/14243102-3848-43fc-82bb-a48648536985

- The 'More' menu can now be opened under the mouse, through the context menu action (right click/control-click on Mac/menu button on keyboard).
- Add copy-components button to menu.
- The menu can now be opened while multiple components are selected; if the clicked component was among the selected components, the selection will be preserved. Some menu actions--currently *copy* and *delete*, apply to all selected components. These actions will change their displayed labels when multiple components are selected. If a single-component action is executed, the component it was applied to will become the sole selection.

Fixes #11633, #11634

(cherry picked from commit 0b6b1f0)
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🗄️ Archived
Development

Successfully merging a pull request may close this issue.

2 participants