Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename workflow button only works once #11101

Closed
AdRiley opened this issue Sep 17, 2024 · 0 comments · Fixed by #11103
Closed

Rename workflow button only works once #11101

AdRiley opened this issue Sep 17, 2024 · 0 comments · Fixed by #11103
Assignees
@farmaazon
Labels
--bug Type: bug -gui p-high Should be completed in the next sprint
Milestone
2024-09 Release

Comments

@AdRiley
Copy link
Member

AdRiley commented Sep 17, 2024

Repro steps:

  1. Create a new workflow (local)
  2. Click the rename workflow button. The workflow name text gets selected and if I wanted to I could rename the workflow.
  3. DON'T rename the workflow, but instead cancel by clicking on the graph editor background.
  4. Click the rename workflow button again. The text does not get selected and I cannot rename the workflow

Version 2024.4.1-rc8
Build 2ca6496
Electron 31.2.0
Chrome 126.0.6478.127
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) enso/2024.4.1-rc8 Chrome/126.0.6478.127 Electron/31.2.0 Safari/537.36
@AdRiley AdRiley added p-high Should be completed in the next sprint --bug Type: bug -gui labels Sep 17, 2024
@AdRiley AdRiley added this to the 2024-09 Release milestone Sep 17, 2024
@farmaazon farmaazon added g-electron GUI: electron application specific and removed g-electron GUI: electron application specific labels Sep 17, 2024
@farmaazon farmaazon mentioned this issue Sep 17, 2024
Merged
1 task
@farmaazon farmaazon moved this from ❓New to 👁️ Code review in Issues Board Sep 17, 2024
@farmaazon farmaazon self-assigned this Sep 17, 2024
farmaazon added a commit that referenced this issue Sep 17, 2024
@farmaazon
Renaming project: fix invalid state when the name does not change (#1…
dfc04f4 
…1103)

Fixes #11101

I did not add tests for it, because I think we'll remove this rename feature in the future.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Sep 17, 2024
jdunkerley pushed a commit that referenced this issue Sep 17, 2024
@farmaazon @jdunkerley
Renaming project: fix invalid state when the name does not change (#1…
0857604 
…1103)

Fixes #11101

I did not add tests for it, because I think we'll remove this rename feature in the future.

(cherry picked from commit dfc04f4)
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farmaazon farmaazon

Labels
--bug Type: bug -gui p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
2024-09 Release
Development

Successfully merging a pull request may close this issue.

Renaming project: fix invalid state when the name does not change enso-org/enso
2 participants
@AdRiley @farmaazon