Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable widget for Table.new #10484

Closed
Tracked by #10293
farmaazon opened this issue Jul 9, 2024 · 8 comments · Fixed by #10599
Closed
Tracked by #10293

Resizable widget for Table.new #10484

farmaazon opened this issue Jul 9, 2024 · 8 comments · Fixed by #10599
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request

Comments

@farmaazon
Copy link
Contributor

First step of implementing #10293

Create widget which matches Table.new with simple fields (no cells like 2 + 2) being only a top-level node's call. The widget should not display anything in particular in this task, but it should be resizable (and node should change size as well).

@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request -gui labels Jul 9, 2024
@farmaazon farmaazon added this to the 2024-08 Release milestone Jul 9, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Jul 9, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Jul 9, 2024
@Frizi Frizi self-assigned this Jul 10, 2024
@Frizi Frizi moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jul 10, 2024
@Frizi Frizi moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jul 19, 2024
@farmaazon farmaazon moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jul 22, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jul 23, 2024
mergify bot pushed a commit that referenced this issue Jul 25, 2024
…` widget stub (#10599)

Implements #10484, also fixed an issue with dropdown arrow icon being pointed in the wrong direction.

Changed the way we handle spacing around ports and other rounded widgets. Now it is the innermost token element that actually pads itself when appropriate, allowing rounded widgets to stay tightly nested together. This cleans up an issue we've had with an unnecessary padding at the end of node, and makes margins easier to control in general.


<img width="371" alt="image" src="https://github.com/user-attachments/assets/4aa2ae0f-06f6-45fd-b7a1-1b7c0f60d395">
@mergify mergify bot closed this as completed in #10599 Jul 25, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Archived to 🟢 Accepted in Issues Board Jul 25, 2024
jdunkerley pushed a commit that referenced this issue Jul 26, 2024
…` widget stub (#10599)

Implements #10484, also fixed an issue with dropdown arrow icon being pointed in the wrong direction.

Changed the way we handle spacing around ports and other rounded widgets. Now it is the innermost token element that actually pads itself when appropriate, allowing rounded widgets to stay tightly nested together. This cleans up an issue we've had with an unnecessary padding at the end of node, and makes margins easier to control in general.

<img width="371" alt="image" src="https://github.com/user-attachments/assets/4aa2ae0f-06f6-45fd-b7a1-1b7c0f60d395">

(cherry picked from commit 8a3180e)
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jul 29, 2024
@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-12):

Progress: Hunting for all places where we hardcoded node height, attempting to replace them with proper flexible layout. It should be finished by 2024-07-25.

@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-15):

Progress: Continuing flexible layout refactor. Started refactoring handling of widget margins assignment for rounded elements. It should be finished by 2024-07-25.

@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-16):

Progress: Continuing margin handling refactor. It should be finished by 2024-07-25.

@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-17):

Progress: Finished implementing new margin handling. Created basic table widget stub. Hunting for breaking layout in presence of large widgets. It should be finished by 2024-07-25.

@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-18):

Progress: Added resize hand It should be finished by 2024-07-25.

@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-22):

Progress: Merged with latest develop and addressed CI failures, fixed widget selection priority conflict between hierarchy and access chain widgets. It should be finished by 2024-07-25.

@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-23):

Progress: Fixed new icon logic that was incorrectly hiding access chains for static method applications. It should be finished by 2024-07-25.

@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-25):

Progress: Finished issues after merge conflict caused by introduction of special shapes for output nodes. Refactored node icons to always be rendered using a widget, removing special case for non-application expressions. It should be finished by 2024-07-25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants