Skip to content

Commit

Permalink
Update electron-builder to v23.0.6 (#3410)
Browse files Browse the repository at this point in the history
[ci no changelog needed]

[Task link](https://www.pivotaltracker.com/story/show/181944234).

It fixes the build issue on Mac OS 12.3.1 that is caused by removed `/usr/bin/python` executable.

Also applied `enso-formatter` to the sources.

# Important Notes
We're basically updating for one major `electron-builder` release - from `v22` to `v23`. I didn't spot anything in the changelog that could affect us. See features + breaking changes excerpt:

```
Features:

- feat(msi): add fileAssociation support for MSI target (electron-userland/electron-builder#6530)
- feat(mac): ElectronAsarIntegrity in electron@15 - See: electron/electron#30667 (electron-userland/electron-builder#6506 electron-userland/electron-builder#6507)
- feat(snap): add lzo to Snap compression options (also as new default) (electron-userland/electron-builder#6201) Upgraded app-builder-bin dependency required newer version of Go
- feat(msi): support assisted installer for MSI target (electron-userland/electron-builder#6550)

Breaking changes:

- Removing Bintray support since it was sunset. Ref: https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
- Fail-fast for windows signature verification failures. Adding -LiteralPath to update file path to disregard injected wildcards
- Force strip path separators for backslashes on Windows during update process
- Authentication for local mac squirrel update server
- Disabled advertised shortcuts, since MSIs with advertised Start Menu shortcuts that have a
Shortcut Property fails to install when deployed machine-wide via GPO but works fine in all
other contexts. Admins using advertisement must apply an MST to re-enable it. See electron-userland/electron-builder#6508.
- Removing optional NSIS icon ID from config and generating it automatically to synchronize IDs with Advertised Shortcuts and future features
```
  • Loading branch information
vitvakatu authored Apr 21, 2022
1 parent e8342b0 commit ea33387
Show file tree
Hide file tree
Showing 9 changed files with 1,180 additions and 1,314 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use crate::language_server::*;
use strum_macros::IntoStaticStr;



// =============
// === Event ===
// =============
Expand Down
5 changes: 5 additions & 0 deletions app/gui/enso-profiler-metadata/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
//! Enso specific metadata logging utilities for use with the profiling framework.
// === Standard Linter Configuration ===
#![deny(non_ascii_idents)]
#![warn(unsafe_code)]

use serde::Serializer;
use std::fmt::Display;
use std::fmt::Formatter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,18 @@
use ensogl::prelude::*;

use crate::application::command::FrpNetworkProvider;
use crate::GraphEditorModelWithNetwork;
use crate::NodeId;

use crate::application::command::FrpNetworkProvider;
use enso_frp as frp;
use ensogl::animation::easing::EndStatus::Normal;
use ensogl::display::Scene;
use ensogl::Animation;
use ensogl::Easing;



/// Describes the "speed" of growth/shrink animation.
///
/// To determine the duration of the blending animation, we divide the length of the camera path by
Expand Down
2 changes: 1 addition & 1 deletion app/ide-desktop/lib/client/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ let config = {
'copy-webpack-plugin': '^5.1.1',
devtron: '^1.4.0',
electron: '17.1.0',
'electron-builder': '^22.14.13',
'electron-builder': '^23.0.6',
'crypto-js': '4.0.0',
'electron-notarize': '1.1.1',
},
Expand Down
Loading

0 comments on commit ea33387

Please sign in to comment.