implement problem reporting

distribution/lib/Standard/Table/0.0.0-dev/src/Data/Column.enso

@@ -1328,9 +1328,11 @@ type Column
     cast self value_type=Value_Type.Char on_problems=Problem_Behavior.Report_Warning =
         Cast_Helpers.check_cast_compatibility self.value_type value_type . if_not_error <|
             target_storage_type = Storage.from_value_type value_type on_problems
-            # TODO problem handling will be handled as part of #5159
-            new_storage = self.java_column.getStorage.cast target_storage_type
-            Column.from_storage self.name new_storage
+            cast_problem_builder = Cast_Helpers.new_java_problem_builder self.name value_type
+            new_storage = self.java_column.getStorage.cast target_storage_type cast_problem_builder.to_java
+            problems = cast_problem_builder.get_problems
+            on_problems.attach_problems_before problems <|
+                Column.from_storage self.name new_storage
 
     ## ALIAS Transform Column
 

distribution/lib/Standard/Table/0.0.0-dev/src/Errors.enso

@@ -564,7 +564,7 @@ type Lossy_Conversion
     to_display_text self =
         rows_info = case self.affected_rows_count of
             Nothing -> ""
-            Just count -> " in "+count.to_text+" rows"
+            count -> " in "+count.to_text+" rows"
         "When converting the column ["+self.related_column+"], the target type ("+self.target_type.to_display_text+") does not fill all the data, so some information was lost"+rows_info+"."
 
 type Invalid_Value_For_Type

distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Cast_Helpers.enso

@@ -3,6 +3,9 @@ import Standard.Base.Errors.Illegal_Argument.Illegal_Argument
 
 import project.Data.Type.Value_Type.Value_Type
 import project.Internal.Parse_Values_Helper
+from project.Errors import Lossy_Conversion
+
+polyglot java import org.enso.table.data.column.operation.CastProblemBuilder
 
 ## PRIVATE
    Checks if one type can be cast into another and returns a dataflow error
@@ -28,3 +31,26 @@ is_a_valid_parse_target target_type =
         atom : Meta.Atom ->
             Parse_Values_Helper.valid_parse_targets.contains atom.constructor.name
         _ -> False
+
+## PRIVATE
+type Cast_Problem_Builder
+    ## PRIVATE
+    Value column_name target_type to_java
+
+    ## PRIVATE
+       Returns a vector of all reported problems.
+    get_problems : Vector
+    get_problems self =
+        builder = Vector.new_builder
+        java_instance = self.to_java
+
+        lossy_conversion_rows = java_instance.getLossyConversionRowCount
+        if lossy_conversion_rows > 0 then
+            builder.append (Lossy_Conversion.Error self.target_type self.column_name lossy_conversion_rows)
+
+        builder.to_vector
+
+## PRIVATE
+new_java_problem_builder : Text -> Value_Type -> Cast_Problem_Builder
+new_java_problem_builder column_name target_type =
+    Cast_Problem_Builder.Value column_name target_type CastProblemBuilder.new

std-bits/table/src/main/java/org/enso/table/data/column/operation/CastProblemBuilder.java

@@ -0,0 +1,12 @@
+package org.enso.table.data.column.operation;
+
+public class CastProblemBuilder {
+  private int lossyConversionRowCount = 0;
+  public void reportLossyConversion() {
+    lossyConversionRowCount++;
+  }
+
+  public int getLossyConversionRowCount() {
+    return lossyConversionRowCount;
+  }
+}

std-bits/table/src/main/java/org/enso/table/data/column/storage/BoolStorage.java

@@ -7,7 +7,7 @@
 import org.enso.table.data.column.builder.object.BoolBuilder;
 import org.enso.table.data.column.builder.object.Builder;
 import org.enso.table.data.column.builder.object.StringBuilder;
-import org.enso.table.data.column.builder.string.StringStorageBuilder;
+import org.enso.table.data.column.operation.CastProblemBuilder;
 import org.enso.table.data.column.operation.map.MapOpStorage;
 import org.enso.table.data.column.operation.map.MapOperation;
 import org.enso.table.data.column.operation.map.MapOperationProblemBuilder;
@@ -400,7 +400,7 @@ public BoolStorage slice(List<SliceRange> ranges) {
   }
 
   @Override
-  public Storage<?> cast(StorageType targetType) {
+  public Storage<?> cast(StorageType targetType, CastProblemBuilder castProblemBuilder) {
     return switch (targetType) {
       case AnyObjectType any ->
         new MixedStorageFacade(this);

std-bits/table/src/main/java/org/enso/table/data/column/storage/DateStorage.java

@@ -7,6 +7,7 @@
 import org.enso.table.data.column.builder.object.Builder;
 import org.enso.table.data.column.builder.object.DateBuilder;
 import org.enso.table.data.column.builder.object.DateTimeBuilder;
+import org.enso.table.data.column.operation.CastProblemBuilder;
 import org.enso.table.data.column.operation.map.MapOpStorage;
 import org.enso.table.data.column.operation.map.UnaryIntegerOp;
 import org.enso.table.data.column.operation.map.datetime.DateTimeIsInOp;
@@ -73,7 +74,7 @@ public Builder createDefaultBuilderOfSameType(int capacity) {
   }
 
   @Override
-  public Storage<?> cast(StorageType targetType) {
+  public Storage<?> cast(StorageType targetType, CastProblemBuilder castProblemBuilder) {
     if (targetType instanceof DateTimeType) {
       int n = size();
       DateTimeBuilder builder = new DateTimeBuilder(n);
@@ -88,7 +89,7 @@ public Storage<?> cast(StorageType targetType) {
       }
       return builder.seal();
     } else {
-      return super.cast(targetType);
+      return super.cast(targetType, castProblemBuilder);
     }
   }
 }

std-bits/table/src/main/java/org/enso/table/data/column/storage/DateTimeStorage.java

@@ -4,6 +4,7 @@
 import org.enso.table.data.column.builder.object.DateBuilder;
 import org.enso.table.data.column.builder.object.DateTimeBuilder;
 import org.enso.table.data.column.builder.object.TimeOfDayBuilder;
+import org.enso.table.data.column.operation.CastProblemBuilder;
 import org.enso.table.data.column.operation.map.MapOpStorage;
 import org.enso.table.data.column.operation.map.UnaryIntegerOp;
 import org.enso.table.data.column.operation.map.datetime.DateTimeIsInOp;
@@ -14,7 +15,6 @@
 
 import java.time.LocalDate;
 import java.time.LocalTime;
-import java.time.ZoneId;
 import java.time.ZonedDateTime;
 
 public final class DateTimeStorage extends SpecializedStorage<ZonedDateTime> {
@@ -78,7 +78,7 @@ public Builder createDefaultBuilderOfSameType(int capacity) {
   }
 
   @Override
-  public Storage<?> cast(StorageType targetType) {
+  public Storage<?> cast(StorageType targetType, CastProblemBuilder castProblemBuilder) {
     if (targetType instanceof DateType) {
       int n = size();
       DateBuilder builder = new DateBuilder(n);
@@ -106,7 +106,7 @@ public Storage<?> cast(StorageType targetType) {
       }
       return builder.seal();
     } else {
-      return super.cast(targetType);
+      return super.cast(targetType, castProblemBuilder);
     }
   }
 }

std-bits/table/src/main/java/org/enso/table/data/column/storage/DoubleStorage.java

@@ -3,6 +3,7 @@
 import org.enso.table.data.column.builder.object.Builder;
 import org.enso.table.data.column.builder.object.NumericBuilder;
 import org.enso.table.data.column.builder.object.StringBuilder;
+import org.enso.table.data.column.operation.CastProblemBuilder;
 import org.enso.table.data.column.operation.map.MapOpStorage;
 import org.enso.table.data.column.operation.map.MapOperationProblemBuilder;
 import org.enso.table.data.column.operation.map.UnaryMapOperation;
@@ -369,7 +370,7 @@ public Storage<Double> slice(List<SliceRange> ranges) {
   }
 
   @Override
-  public Storage<?> cast(StorageType targetType) {
+  public Storage<?> cast(StorageType targetType, CastProblemBuilder castProblemBuilder) {
     return switch (targetType) {
       case AnyObjectType any -> new MixedStorageFacade(this);
       case FloatType floatType -> this;
@@ -384,8 +385,8 @@ public Storage<?> cast(StorageType targetType) {
           } else {
             double value = getItem(i);
             if (value < min || value > max) {
-              // TODO report warning
               builder.appendNulls(1);
+              castProblemBuilder.reportLossyConversion();
             } else {
               long converted = (long) value;
               builder.appendLong(converted);

std-bits/table/src/main/java/org/enso/table/data/column/storage/LongStorage.java

@@ -4,6 +4,7 @@
 import org.enso.table.data.column.builder.object.Builder;
 import org.enso.table.data.column.builder.object.NumericBuilder;
 import org.enso.table.data.column.builder.object.StringBuilder;
+import org.enso.table.data.column.operation.CastProblemBuilder;
 import org.enso.table.data.column.operation.map.MapOpStorage;
 import org.enso.table.data.column.operation.map.MapOperationProblemBuilder;
 import org.enso.table.data.column.operation.map.UnaryMapOperation;
@@ -458,7 +459,7 @@ public LongStorage slice(List<SliceRange> ranges) {
   }
 
   @Override
-  public Storage<?> cast(StorageType targetType) {
+  public Storage<?> cast(StorageType targetType, CastProblemBuilder castProblemBuilder) {
     return switch (targetType) {
       case AnyObjectType any -> new MixedStorageFacade(this);
       case IntegerType integerType -> this;

std-bits/table/src/main/java/org/enso/table/data/column/storage/MixedStorageFacade.java

@@ -1,6 +1,7 @@
 package org.enso.table.data.column.storage;
 
 import org.enso.table.data.column.builder.object.Builder;
+import org.enso.table.data.column.operation.CastProblemBuilder;
 import org.enso.table.data.column.operation.map.MapOperationProblemBuilder;
 import org.enso.table.data.column.storage.type.AnyObjectType;
 import org.enso.table.data.column.storage.type.StorageType;
@@ -101,7 +102,7 @@ public Storage<Object> slice(List<SliceRange> ranges) {
   }
 
   @Override
-  public Storage<?> cast(StorageType targetType) {
+  public Storage<?> cast(StorageType targetType, CastProblemBuilder castProblemBuilder) {
     return null;
   }
 }

std-bits/table/src/main/java/org/enso/table/data/column/storage/SpecializedStorage.java

@@ -4,6 +4,7 @@
 import java.util.List;
 
 import org.enso.table.data.column.builder.object.StringBuilder;
+import org.enso.table.data.column.operation.CastProblemBuilder;
 import org.enso.table.data.column.operation.map.MapOpStorage;
 import org.enso.table.data.column.operation.map.MapOperationProblemBuilder;
 import org.enso.table.data.column.storage.type.AnyObjectType;
@@ -155,7 +156,7 @@ public SpecializedStorage<T> slice(List<SliceRange> ranges) {
   }
 
   @Override
-  public Storage<?> cast(StorageType targetType) {
+  public Storage<?> cast(StorageType targetType, CastProblemBuilder castProblemBuilder) {
     if (targetType == getType()) {
       return this;
     } else if (targetType instanceof AnyObjectType) {

std-bits/table/src/main/java/org/enso/table/data/column/storage/Storage.java

@@ -4,6 +4,7 @@
 import org.enso.table.data.column.builder.object.Builder;
 import org.enso.table.data.column.builder.object.InferredBuilder;
 import org.enso.table.data.column.builder.object.ObjectBuilder;
+import org.enso.table.data.column.operation.CastProblemBuilder;
 import org.enso.table.data.column.operation.map.MapOperationProblemBuilder;
 import org.enso.table.data.column.storage.type.StorageType;
 import org.enso.table.data.mask.OrderMask;
@@ -346,5 +347,5 @@ public Storage<?> duplicateCount() {
     return new LongStorage(data);
   }
 
-  public abstract Storage<?> cast(StorageType targetType);
+  public abstract Storage<?> cast(StorageType targetType, CastProblemBuilder castProblemBuilder);
 }

std-bits/table/src/main/java/org/enso/table/data/column/storage/StringStorage.java

@@ -4,6 +4,7 @@
 import org.enso.base.Text_Utils;
 import org.enso.table.data.column.builder.object.Builder;
 import org.enso.table.data.column.builder.object.StringBuilder;
+import org.enso.table.data.column.operation.CastProblemBuilder;
 import org.enso.table.data.column.operation.map.MapOpStorage;
 import org.enso.table.data.column.operation.map.MapOperation;
 import org.enso.table.data.column.operation.map.MapOperationProblemBuilder;
@@ -73,7 +74,7 @@ public Builder createDefaultBuilderOfSameType(int capacity) {
   }
 
   @Override
-  public Storage<?> cast(StorageType targetType) {
+  public Storage<?> cast(StorageType targetType, CastProblemBuilder castProblemBuilder) {
     return switch (targetType) {
       case AnyObjectType any -> new MixedStorageFacade(this);
       case TextType textType -> adapt(this, textType);

test/Tests/polyglot-sources/enso-test-java-helpers/src/main/java/org/enso/table_test_helpers/ExplodingStorage.java

@@ -1,6 +1,7 @@
 package org.enso.table_test_helpers;
 
 import org.enso.table.data.column.builder.object.Builder;
+import org.enso.table.data.column.operation.CastProblemBuilder;
 import org.enso.table.data.column.operation.map.MapOperationProblemBuilder;
 import org.enso.table.data.column.storage.Storage;
 import org.enso.table.data.column.storage.type.IntegerType;
@@ -109,7 +110,7 @@ public Storage<Long> slice(List<SliceRange> ranges) {
   }
 
   @Override
-  public Storage<?> cast(StorageType targetType) {
+  public Storage<?> cast(StorageType targetType, CastProblemBuilder castProblemBuilder) {
         return null;
     }
 }