Merge branch 'develop' into wip/frizi/bazel

enso-org · Oct 21, 2024 · 9346a1c · 9346a1c
2 parents f2e2aa5 + 7718734
commit 9346a1c
Show file tree

Hide file tree

Showing 374 changed files with 6,919 additions and 4,081 deletions.
diff --git a/.github/workflows/engine-nightly.yml b/.github/workflows/engine-nightly.yml
@@ -107,7 +107,7 @@ jobs:
   enso-build-ci-gen-job-ci-check-backend-graal-vm-ce-macos-amd64:
     name: Engine (GraalVM CE) (macos, amd64)
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack
@@ -354,7 +354,7 @@ jobs:
   enso-build-ci-gen-job-jvm-tests-graal-vm-ce-macos-amd64:
     name: JVM Tests (GraalVM CE) (macos, amd64)
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack
@@ -640,7 +640,7 @@ jobs:
   enso-build-ci-gen-job-standard-library-tests-graal-vm-ce-macos-amd64:
     name: Standard Library Tests (GraalVM CE) (macos, amd64)
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack

diff --git a/.github/workflows/enso4igv.yml b/.github/workflows/enso4igv.yml
@@ -39,7 +39,7 @@ jobs:
             target/lib/**
 
   build_mac_intel_parser:
-    runs-on: macos-12
+    runs-on: macos-13
 
     steps:
       - uses: actions/checkout@v4

diff --git a/.github/workflows/gui.yml b/.github/workflows/gui.yml
@@ -61,7 +61,7 @@ jobs:
   enso-build-ci-gen-job-build-backend-macos-amd64:
     name: Build Backend (macos, amd64)
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack
@@ -213,7 +213,7 @@ jobs:
   enso-build-ci-gen-job-gui-build-macos-amd64:
     name: GUI build (macos, amd64)
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack
@@ -391,7 +391,7 @@ jobs:
     needs:
       - enso-build-ci-gen-job-build-backend-macos-amd64
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -202,7 +202,7 @@ jobs:
     needs:
       - enso-build-ci-gen-draft-release-linux-amd64
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack
@@ -484,7 +484,7 @@ jobs:
       - enso-build-ci-gen-draft-release-linux-amd64
       - enso-build-ci-gen-job-upload-backend-macos-amd64
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack

diff --git a/.github/workflows/scala-new.yml b/.github/workflows/scala-new.yml
@@ -75,7 +75,7 @@ jobs:
   enso-build-ci-gen-job-ci-check-backend-graal-vm-ce-macos-amd64:
     name: Engine (GraalVM CE) (macos, amd64)
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack
@@ -220,7 +220,7 @@ jobs:
   enso-build-ci-gen-job-jvm-tests-graal-vm-ce-macos-amd64:
     name: JVM Tests (GraalVM CE) (macos, amd64)
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack
@@ -390,7 +390,7 @@ jobs:
   enso-build-ci-gen-job-standard-library-tests-graal-vm-ce-macos-amd64:
     name: Standard Library Tests (GraalVM CE) (macos, amd64)
     runs-on:
-      - macos-12
+      - macos-13
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,8 +4,15 @@
 
 - [Rows and Columns may be now removed in Table Input Widget][11151]. The option
   is available in right-click context menu.
+- [Rows and Columns may be now reordered by dragging in Table Input
+  Widget][11271]
+- [Copying and pasting in Table Editor Widget now works properly][11332]
+- [Fix invisible selection in Table Input Widget][11358]
 
 [11151]: https://github.com/enso-org/enso/pull/11151
+[11271]: https://github.com/enso-org/enso/pull/11271
+[11332]: https://github.com/enso-org/enso/pull/11332
+[11358]: https://github.com/enso-org/enso/pull/11358
 
 #### Enso Standard Library
 

diff --git a/app/common/package.json b/app/common/package.json
@@ -17,7 +17,8 @@
   },
   "scripts": {
     "test": "vitest run",
-    "compile": "tsc"
+    "compile": "tsc",
+    "lint": "eslint . --max-warnings=0"
   },
   "peerDependencies": {
     "@tanstack/query-core": "5.54.1",

diff --git a/app/common/src/accessToken.ts b/app/common/src/accessToken.ts
@@ -4,18 +4,18 @@
 // === AccessToken ===
 // ===================
 
-/** Payload for the `save-access-token` event that saves an access token to a credentials file. */
+/** Credentials to be saved to a credentials file. */
 export interface AccessToken {
-  /** The JWT token to save. */
+  /** The user's JWT token. */
   readonly accessToken: string
-  /** The Cognito app integration client id. */
+  /** The ID for the Cognito app integration. */
   readonly clientId: string
-  /** The refresh token taken from authorization flow. */
+  /** The refresh token taken from the authorization flow. */
   readonly refreshToken: string
-  /** The Cognito url to refresh the token. */
+  /** The Cognito URL to refresh the token. */
   readonly refreshUrl: string
   /**
-   * The when the token will expire.
+   * The expiry time of the token.
    * This is a string representation of a date in ISO 8601 format (e.g. "2021-01-01T00:00:00Z").
    */
   readonly expireAt: string

diff --git a/app/common/src/buildUtils.d.ts b/app/common/src/buildUtils.d.ts
@@ -3,26 +3,34 @@
 /** Indent size for stringifying JSON. */
 export const INDENT_SIZE: number
 
-/** Get the environment variable value.
+/**
+ * Get the environment variable value.
  * @param name - The name of the environment variable.
  * @returns The value of the environment variable.
- * @throws {Error} If the environment variable is not set. */
+ * @throws {Error} If the environment variable is not set.
+ */
 export function requireEnv(name: string): string
 
-/** Read the path from environment variable and resolve it.
+/**
+ * Read the path from environment variable and resolve it.
  * @param name - The name of the environment variable.
  * @returns The resolved path.
- * @throws {Error} If the environment variable is not set. */
+ * @throws {Error} If the environment variable is not set.
+ */
 export function requireEnvResolvedPath(name: string): string
 
-/** Read the path from environment variable and resolve it. Verify that it exists.
+/**
+ * Read the path from environment variable and resolve it. Verify that it exists.
  * @param name - The name of the environment variable.
  * @returns The resolved path.
- * @throws {Error} If the environment variable is not set or path does not exist. */
+ * @throws {Error} If the environment variable is not set or path does not exist.
+ */
 export function requireEnvPathExist(name: string): string
 
-/** Get the common prefix of the two strings.
+/**
+ * Get the common prefix of the two strings.
  * @param a - the first string.
  * @param b - the second string.
- * @returns The common prefix. */
+ * @returns The common prefix.
+ */
 export function getCommonPrefix(a: string, b: string): string
diff --git a/app/common/src/index.ts b/app/common/src/index.ts
@@ -1,18 +1,22 @@
-/** @file This module contains metadata about the product and distribution,
+/**
+ * @file This module contains metadata about the product and distribution,
  * and various other constants that are needed in multiple sibling packages.
  *
  * Code in this package is used by two or more sibling packages of this package. The code is defined
  * here when it is not possible for a sibling package to own that code without introducing a
- * circular dependency in our packages. */
+ * circular dependency in our packages.
+ */
 
 // ========================
 // === Product metadata ===
 // ========================
 
-/** URL protocol scheme for deep links to authentication flow pages, without the `:` suffix.
+/**
+ * URL protocol scheme for deep links to authentication flow pages, without the `:` suffix.
  *
  * For example: the deep link URL
- * `enso://authentication/register?code=...&state=...` uses this scheme. */
+ * `enso://authentication/register?code=...&state=...` uses this scheme
+ */
 export const DEEP_LINK_SCHEME: string = 'enso'
 
 /** Name of the product. */
@@ -21,15 +25,18 @@ export const PRODUCT_NAME: string = 'Enso'
 /** Company name, used as the copyright holder. */
 export const COMPANY_NAME: string = 'New Byte Order sp. z o.o.'
 
-/** The domain on which the Cloud Dashboard web app is hosted.
- * Excludes the protocol (`https://`). */
+/**
+ * The domain on which the Cloud Dashboard web app is hosted.
+ * Excludes the protocol (`https://`).
+ */
 export const CLOUD_DASHBOARD_DOMAIN: string = 'cloud.enso.org'
 
-/** @type {[header: string, value: string][]}
+/**
  * COOP, COEP, and CORP headers: https://web.dev/coop-coep/
  *
  * These are required to increase the resolution of `performance.now()` timers,
- * making profiling a lot more accurate and consistent. */
+ * making profiling a lot more accurate and consistent.
+ */
 export const COOP_COEP_CORP_HEADERS: [header: string, value: string][] = [
   ['Cross-Origin-Opener-Policy', 'same-origin'],
   ['Cross-Origin-Resource-Policy', 'same-origin'],

diff --git a/app/common/src/queryClient.ts b/app/common/src/queryClient.ts
@@ -10,29 +10,21 @@ import * as vueQuery from '@tanstack/vue-query'
 import * as idbKeyval from 'idb-keyval'
 
 declare module '@tanstack/query-core' {
-  /**
-   * Query client with additional methods.
-   */
+  /** Query client with additional methods. */
   interface QueryClient {
     /**
      * Clear the cache stored in Tanstack Query and the persister storage.
      * Please use this method with caution, as it will clear all cache data.
      * Usually you should use `queryClient.invalidateQueries` instead.
      */
     readonly clearWithPersister: () => Promise<void>
-    /**
-     * Clear the cache stored in the persister storage.
-     */
+    /** Clear the cache stored in the persister storage. */
     readonly nukePersister: () => Promise<void>
   }
-  /**
-   * Specifies the invalidation behavior of a mutation.
-   */
+  /** Specifies the invalidation behavior of a mutation. */
   interface Register {
     readonly mutationMeta: {
-      /**
-       * List of query keys to invalidate when the mutation succeeds.
-       */
+      /** List of query keys to invalidate when the mutation succeeds. */
       readonly invalidates?: queryCore.QueryKey[]
       /**
        * List of query keys to await invalidation before the mutation is considered successful.
@@ -71,9 +63,7 @@ const DEFAULT_QUERY_PERSIST_TIME_MS = 30 * 24 * 60 * 60 * 1000 // 30 days
 
 const DEFAULT_BUSTER = 'v1.1'
 
-/**
- * Create a new Tanstack Query client.
- */
+/** Create a new Tanstack Query client. */
 export function createQueryClient(): QueryClient {
   const store = idbKeyval.createStore('enso', 'query-persist-cache')
   queryCore.onlineManager.setOnline(navigator.onLine)