Move types into namespace so that they can be imported

[G-Rath]

This allows access to the types without being a breaking change.

[G-Rath]

This diff looks a bit odd b/c for git the smallest way to express the change is to actually move the start of the namespace and the classes above it to the top of the file, rather than moving the interfaces into the namespace.

So the visualisation of this diff is inverse to it's result :)

[G-Rath]

@doowb could I get a review on this? (I can't request reviews anymore due to the age 😬)

[doowb]

@G-Rath thanks for the PR. Sorry for not responding sooner. There are a lot of TypeScript related PRs and since I'm not as familiar with TypeScript, I've been trying to make sure I understand what type of affects the changes might have.

From your initial description, this one looks like it will just "add" functionality by exposing more of the Types and Interfaces through the Enquirer namespace.

I just merged in #266, which updated index.d.ts a little. Will you "rebase" with that, then fix the indentation so it's easy to see the types and interfaces that are inside the namespace. (I realize that the BasePrompt class declaration already had bad indentation, so it would be awesome if you caught that too).

Thank you.

[g-plane]

There's an existing PR: #82. However, it's still not merged.

[G-Rath]

this one looks like it will just "add" functionality by exposing more of the Types and Interfaces through the Enquirer namespace.

Exactly. This isn't a breaking change :)

[G-Rath]

@doowb I've rebased this PR - let me know if you'd like any other changes :)

[G-Rath]

@jonschlinkert @doowb any chance of getting this reviewed & merged? While it sounds like #307 is going to greatly improve on things, it's a big PR that could require work for apps to update to when it is finally released.

Meanwhile this change is very simple, not breaking, and so should provide a good middle ground to improve TS support while waiting for #307 to land :)

[jonschlinkert]

We’ll review asap

…

Sent from my iPhone

On Oct 18, 2020, at 7:39 PM, Gareth Jones ***@***.***> wrote:  @jonschlinkert @doowb any chance of getting this reviewed & merged? While it sounds like #307 is going to greatly improve on things, it's a big PR that could require work for apps to update to when it is finally released. Meanwhile this change is very simple, not breaking, and so should provide a good middle ground to improve TS support while waiting for #307 to land :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[G-Rath]

@jonschlinkert any update?

[jonschlinkert]

Sorry for the delay, I'l merge and publish asap.

[G-Rath]

@jonschlinkert I hate to be a pain, but any chance of getting this merged & released? I'm kicking off a new TypeScript project that I'd like to use enquirer for, but without this change it's making it pretty hard

[kevinkhill]

It's been over a year :(

[kevinkhill]

This is what I meant. Empty promises.