-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrement Redis Counter for Errored Sidekiq Jobs #24
Merged
SheffAtEnova
merged 4 commits into
enova:main
from
hkim3162:add_decrement_counter_for_errored
Jun 26, 2023
Merged
Decrement Redis Counter for Errored Sidekiq Jobs #24
SheffAtEnova
merged 4 commits into
enova:main
from
hkim3162:add_decrement_counter_for_errored
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packrat386
reviewed
May 31, 2023
be6c334
to
3a3e359
Compare
4e9c829
to
f94749a
Compare
8baa818
to
652fe7d
Compare
SheffAtEnova
suggested changes
Jun 22, 2023
8414600
to
f551002
Compare
f551002
to
e9061cc
Compare
SheffAtEnova
suggested changes
Jun 26, 2023
1d1fe07
to
3e85f78
Compare
3e85f78
to
99efb15
Compare
SheffAtEnova
suggested changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more last bits in line with the rest of the feedback.
SheffAtEnova
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sidekiq Instrument, ensure that in the rescue block of when a job errors that we continue to decrement the counter. When jobs are errored the enqueue increment never gets removed
ensure
block