Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application config is not available in main.js (#6608) #6686

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

aro
Copy link
Contributor

@aro aro commented Oct 24, 2018

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #6686 into master will increase coverage by <.01%.
The diff coverage is 89.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6686      +/-   ##
============================================
+ Coverage     80.44%   80.45%   +<.01%     
- Complexity    16830    16838       +8     
============================================
  Files          2411     2411              
  Lines         59917    59941      +24     
  Branches       5188     5193       +5     
============================================
+ Hits          48200    48223      +23     
+ Misses         8951     8950       -1     
- Partials       2766     2768       +2
Impacted Files Coverage Δ Complexity Δ
.../xp/core/impl/app/config/ApplicationConfigMap.java 77.77% <100%> (+17.77%) 4 <1> (+1) ⬆️
...om/enonic/xp/core/impl/app/ApplicationFactory.java 89.47% <88.88%> (-1.16%) 17 <7> (+7)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd1118...06edb16. Read the comment docs.

@GlennRicaud GlennRicaud merged commit 2697576 into master Oct 24, 2018
@GlennRicaud GlennRicaud deleted the issue-6608 branch October 24, 2018 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants