Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media image API handler #10882 #10924

Merged
merged 9 commits into from
Feb 27, 2025
Merged

Media image API handler #10882 #10924

merged 9 commits into from
Feb 27, 2025

Conversation

anatol-sialitski
Copy link
Contributor

No description provided.

@anatol-sialitski anatol-sialitski linked an issue Feb 19, 2025 that may be closed by this pull request
Media image API handler #10882
Closed
@enonic enonic deleted a comment from codacy-production bot Feb 20, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.34010% with 21 lines in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (20e113c) to head (cd4bd0b).
Report is 13 commits behind head on media-epic.

Files with missing lines Patch % Lines
.../portal/impl/handler/image/ImageHandlerWorker.java 30.76% 5 Missing and 4 partials ⚠️
...a/com/enonic/xp/portal/impl/MediaHashResolver.java 83.33% 2 Missing and 3 partials ⚠️
...nonic/xp/portal/impl/handler/MediaHandlerBase.java 91.66% 1 Missing and 3 partials ⚠️
.../impl/handler/AbstractAttachmentHandlerWorker.java 77.77% 0 Missing and 2 partials ⚠️
.../java/com/enonic/xp/portal/url/ImageUrlParams.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##             media-epic   #10924      +/-   ##
================================================
+ Coverage         84.62%   84.77%   +0.14%     
- Complexity        19993    20138     +145     
================================================
  Files              2628     2640      +12     
  Lines             69475    70048     +573     
  Branches           5605     5606       +1     
================================================
+ Hits              58791    59380     +589     
+ Misses             7979     7954      -25     
- Partials           2705     2714       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatol-sialitski anatol-sialitski marked this pull request as ready for review February 27, 2025 10:43
rymsha
rymsha reviewed Feb 27, 2025
View reviewed changes
...es/portal/portal-impl/src/test/java/com/enonic/xp/portal/impl/handler/ApiDispatcherTest.java Outdated
// test handle
assertEquals( webResponse, this.handler.doHandle( webRequest, webResponse, null ) );
}
// @Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@anatol-sialitski anatol-sialitski merged commit 5686987 into media-epic Feb 27, 2025
6 checks passed
@anatol-sialitski anatol-sialitski deleted the issue-10882 branch February 27, 2025 12:56
anatol-sialitski added a commit that referenced this pull request Feb 27, 2025
@anatol-sialitski
Media image API handler #10882 (#10924)
5b49735 
Media image API handler #10882

Media attachment API handler #10883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymsha rymsha rymsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media image API handler
2 participants
@anatol-sialitski @rymsha