Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiStepDialog.displayStep should return a promise #3526

Closed
alansemenov opened this issue Apr 8, 2024 · 0 comments · Fixed by #3528
Closed

MultiStepDialog.displayStep should return a promise #3526

alansemenov opened this issue Apr 8, 2024 · 0 comments · Fixed by #3528
Assignees
@alansemenov
Labels
Refactoring Code improvements

Comments

@alansemenov
Copy link
Member

Some actions inside MultiStepDialog.displayStep can be asynchronous, so we should change it to return a promise to make sure that the following methods wait for displayStep to complete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alansemenov alansemenov

Labels
Refactoring Code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MultiStepDialog.displayStep should return a promise enonic/lib-admin-ui
1 participant
@alansemenov