Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing styles in RichText for images #608 #609

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

anatol-sialitski
Copy link
Contributor

No description provided.

@anatol-sialitski anatol-sialitski linked an issue Oct 11, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (11139ef) 72.91% compared to head (080d748) 73.00%.
Report is 24 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #609      +/-   ##
============================================
+ Coverage     72.91%   73.00%   +0.09%     
+ Complexity      913      870      -43     
============================================
  Files           122      120       -2     
  Lines          4567     4338     -229     
  Branches        459      434      -25     
============================================
- Hits           3330     3167     -163     
+ Misses          958      923      -35     
+ Partials        279      248      -31     
Files Coverage Δ
...a/com/enonic/app/guillotine/graphql/Constants.java 100.00% <ø> (ø)
.../com/enonic/app/guillotine/graphql/GraphQLApi.java 96.77% <100.00%> (-0.07%) ⬇️
...onic/app/guillotine/graphql/GuillotineContext.java 91.11% <100.00%> (+8.65%) ⬆️
...uillotine/graphql/factory/ContentTypesFactory.java 100.00% <100.00%> (ø)
...lotine/graphql/factory/HeadlessCmsTypeFactory.java 100.00% <100.00%> (ø)
.../guillotine/graphql/factory/InputTypesFactory.java 100.00% <ø> (ø)
...phql/fetchers/GetAttachmentUrlByIdDataFetcher.java 100.00% <100.00%> (+75.00%) ⬆️
...ql/fetchers/GetAttachmentUrlByNameDataFetcher.java 100.00% <100.00%> (+76.92%) ⬆️
...hql/fetchers/GetChildrenConnectionDataFetcher.java 95.23% <100.00%> (ø)
...otine/graphql/fetchers/GetChildrenDataFetcher.java 93.33% <100.00%> (ø)
... and 16 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatol-sialitski anatol-sialitski marked this pull request as ready for review November 7, 2023 14:33
@anatol-sialitski anatol-sialitski merged commit c9bb9bb into master Nov 7, 2023
4 checks passed
@anatol-sialitski anatol-sialitski deleted the issue-608 branch November 7, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing styles in RichText for images
2 participants