Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageUrl generation #589 #590

Merged
merged 1 commit into from
Oct 12, 2023
Merged

PageUrl generation #589 #590

merged 1 commit into from
Oct 12, 2023

Conversation

anatol-sialitski
Copy link
Contributor

No description provided.

@anatol-sialitski anatol-sialitski linked an issue Sep 28, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (11139ef) 72.91% compared to head (31b0bef) 72.97%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #590      +/-   ##
============================================
+ Coverage     72.91%   72.97%   +0.05%     
+ Complexity      913      867      -46     
============================================
  Files           122      120       -2     
  Lines          4567     4329     -238     
  Branches        459      432      -27     
============================================
- Hits           3330     3159     -171     
+ Misses          958      922      -36     
+ Partials        279      248      -31     
Files Coverage Δ
...a/com/enonic/app/guillotine/graphql/Constants.java 100.00% <ø> (ø)
.../com/enonic/app/guillotine/graphql/GraphQLApi.java 96.77% <100.00%> (-0.07%) ⬇️
...onic/app/guillotine/graphql/GuillotineContext.java 91.11% <100.00%> (+8.65%) ⬆️
...uillotine/graphql/factory/ContentTypesFactory.java 100.00% <100.00%> (ø)
...p/guillotine/graphql/factory/EnumTypesFactory.java 100.00% <ø> (ø)
...uillotine/graphql/factory/GenericTypesFactory.java 90.54% <100.00%> (ø)
...lotine/graphql/factory/HeadlessCmsTypeFactory.java 100.00% <100.00%> (ø)
.../guillotine/graphql/factory/InputTypesFactory.java 100.00% <ø> (ø)
...phql/fetchers/GetAttachmentUrlByIdDataFetcher.java 100.00% <100.00%> (+75.00%) ⬆️
...ql/fetchers/GetAttachmentUrlByNameDataFetcher.java 100.00% <100.00%> (+76.92%) ⬆️
... and 17 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatol-sialitski anatol-sialitski force-pushed the issue-589 branch 2 times, most recently from 27d67a7 to 855a847 Compare October 2, 2023 13:48
@anatol-sialitski anatol-sialitski force-pushed the issue-589 branch 2 times, most recently from b567b1a to 0374ab4 Compare October 12, 2023 08:48
@anatol-sialitski anatol-sialitski marked this pull request as ready for review October 12, 2023 08:58
@anatol-sialitski anatol-sialitski merged commit bc34407 into master Oct 12, 2023
4 checks passed
@anatol-sialitski anatol-sialitski deleted the issue-589 branch October 12, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PageUrl generation
2 participants