-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (cli): Introduce Enola container image for end-users #396
Conversation
ddfd54f
to
383ee68
Compare
383ee68
to
7beb02d
Compare
Hm, I added a new workflow for that in a 2nd commit on this PR, and it fails with:
Should I already merge this as-is (without doc?), and then create another PR to sort that out later? |
81ccc2d
to
47c6ea9
Compare
Enabling Public instead of Private only Package Creation Permissions on https://github.com/organizations/enola-dev/settings/packages did not help for this. That still smells like it's probably the correct setting, so I'll keep that. Disabling Inherit access from source repository on the Default package settings (hear: "This setting will be applied to new Container, npm, rubygems and NuGet packages.") does not help either; and in fact may be dumb/wrong? I've played with undoing it again, but it doesn't work either way (even after the manual package creation, below). Adding labels does not seem to help. Attempting to manually publishing an initial package's first version, from local workstation instead of GitHub Action, to see if that works... https://github.com/organizations/enola-dev/settings/personal-access-tokens-onboarding says "By default, fine-grained personal access tokens cannot access content owned by your organization via the Public API or Git. This includes both public and private resources such as repositories." so I've enabled that, for now. But when creating a (new style) PAT on https://github.com/settings/personal-access-tokens/new, there are no Package related permissions shown?! So I granted Admin and Repo write etc. but it's NOK; fails with echo ghp_... | podman login ghcr.io -u vorburger --password-stdin
podman tag 174c61a973f9 ghcr.io/enola-dev/enola:test
podman push ghcr.io/enola-dev/enola:test It was private not public by default; I've changed that, via Package settings. Then I've also Manage Actions access > Added Repository for https://github.com/enola-dev/enola on that Package. Lastly I've also Connected Repository to the Package (and it now shows e.g. the I have hunch that perhaps this is blocked from PRs, and only works after merge? I'll go ahead and see if that helps... |
47c6ea9
to
889958d
Compare
That was it indeed! https://github.com/enola-dev/enola/pkgs/container/enola now has it. Except it's
I've reverted that again on https://github.com/organizations/enola-dev/settings/personal-access-tokens.
This is re-enabled on https://github.com/organizations/enola-dev/settings/packages . |
Relates to #180 re. #181.
This PR does not actually publish the container image to
ghcr.io/enola-dev/enola:latest
just yet.