Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Bun hot reloading #1144

Merged
merged 3 commits into from
Mar 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web/.editorconfig
File renamed without changes.
1 change: 1 addition & 0 deletions web/.markdownlint.yaml
1 change: 1 addition & 0 deletions web/.prettierignore
1 change: 1 addition & 0 deletions web/.prettierrc.yaml
4 changes: 4 additions & 0 deletions web/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@

1. `./dev`

[Bun will hot-reload](https://bun.sh/blog/bun-v1.2.3#develop-frontend-apps-with-bun-index-html) on changes!

TODO Hot reloading is broken, see [issue #1143](https://github.com/enola-dev/enola/issues/1143).

### Build

1. `./build`
Expand Down
4 changes: 0 additions & 4 deletions web/ToDo.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@

## Technical

### Productivity

* How to auto rebuild & reload in browser on file change? -- possible with vite or similar build tool

### Bazel

* Use https://github.com/aspect-build/rules_js ... would have worked for `pnpm`, but won't for `bun`...
Expand Down
3 changes: 2 additions & 1 deletion web/src/bun/develop.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ const IGNORE = ["/favicon.ico"]

serve({
port: PORT,
development: true,
development: { hmr: false },

static: {
"/": index as Response,
},
Expand Down
Loading