Skip to content

Commit

Permalink
Add logger dependency to fix warning on Ruby 3.4 (#199)
Browse files Browse the repository at this point in the history
* Add logger dependency to fix warning on Ruby 3.4

Fixes the following warning:

> lib/childprocess.rb:7: warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add logger to your Gemfile or gemspec.

* Add Ruby head to CI matrix

* Pin term-ansicolor gem so CI works on Ruby 2.4

* Fix incorrect rubygems source URL
  • Loading branch information
mattbrictson authored Aug 6, 2024
1 parent 4315989 commit 3a954ed
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
fail-fast: false
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]
ruby: [ '2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3', jruby, truffleruby ]
ruby: [ '2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3', head, jruby, truffleruby ]
# CRuby < 2.6 does not support macos-arm64, so test those on amd64 instead
# JRuby 9.4.7.0 does not have native console support on macos-arm64: https://github.com/jruby/jruby/issues/8271
include:
Expand Down
5 changes: 4 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
source 'http://rubygems.org'
source 'https://rubygems.org'

# Specify your gem's dependencies in child_process.gemspec
gemspec

# Used for local development/testing only
gem 'rake'

# Newer versions of term-ansicolor (used by coveralls) do not work on Ruby 2.4
gem 'term-ansicolor', '< 1.8.0' if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.5')
2 changes: 2 additions & 0 deletions childprocess.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ Gem::Specification.new do |s|

s.required_ruby_version = '>= 2.4.0'

s.add_dependency "logger", "~> 1.5"

s.add_development_dependency "rspec", "~> 3.0"
s.add_development_dependency "yard", "~> 0.0"
s.add_development_dependency 'coveralls', '< 1.0'
Expand Down

0 comments on commit 3a954ed

Please sign in to comment.