fix(client): Should emit closed event when disposing

Closes #108
enisdenjo · Feb 8, 2021 · 5800de8 · 5800de8
1 parent cd12024
commit 5800de8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 8 deletions.
diff --git a/src/client.ts b/src/client.ts
@@ -258,13 +258,6 @@ export function createClient(options: ClientOptions): Client {
           listener(...args);
         }
       },
-      reset() {
-        (Object.keys(listeners) as (keyof typeof listeners)[]).forEach(
-          (event) => {
-            listeners[event] = [];
-          },
-        );
-      },
     };
   })();
 
@@ -554,7 +547,6 @@ export function createClient(options: ClientOptions): Client {
         const socket = await connecting;
         socket.close(1000, 'Normal Closure');
       }
-      emitter.reset();
     },
   };
 }

diff --git a/src/tests/client.ts b/src/tests/client.ts
@@ -1029,4 +1029,22 @@ describe('events', () => {
       expect(cal[0]).toHaveProperty('wasClean');
     });
   });
+
+  it('should emit closed event when disposing', async (done) => {
+    const { url, waitForClient } = await startTServer();
+
+    const client = createClient({
+      url,
+      lazy: false,
+      retryAttempts: 0,
+      onNonLazyError: noop,
+      on: {
+        closed: () => done(),
+      },
+    });
+
+    await waitForClient();
+
+    client.dispose();
+  });
 });