TERNA PR4 & PR5 (Update machinev1) #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal of implementing the Ad-hoc “Accidental Event (No Malice)” Category that includes the “Misconfiguration” example.
sebix
reviewed
May 26, 2021
| @@ -238,7 +243,7 @@ | |||
| "value": "undetermined" | |||
| } | |||
| ], | |||
| "predicate": "other" | |||
| "predicate": "accidental event" | |||
There was a problem hiding this comment.
Why is the "other" taxonomy renamed? that's a major change with big impact
There was a problem hiding this comment.
It's not renamed. I copied the part to introduce "Accidental Event" Category including "Misconfiguration" example (takem from "Availability")
There was a problem hiding this comment.
You created accidental event by copying it, yes. But you also modified the other-taxonomy as these two lines clearly show.
|
concept needs more info to be evaluated: at the moment we have misconfiguration and all the other categories for this. RSIT is not interested in accidental events but security events which stems from that accident. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal of implementing the Ad-hoc “Accidental Event (No Malice)” Category that includes the “Misconfiguration” example.