Dispose widgets to stop leaks. (#108193)

engine-flutter-autoroll · Jul 26, 2022 · e05ae3c · e05ae3c
1 parent dc13fd5
commit e05ae3c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/packages/flutter/lib/src/material/ink_well.dart b/packages/flutter/lib/src/material/ink_well.dart
@@ -847,6 +847,7 @@ class _InkResponseState extends State<_InkResponseStateWidget>
   void dispose() {
     FocusManager.instance.removeHighlightModeListener(handleFocusHighlightModeChange);
     statesController.removeListener(handleStatesControllerChange);
+    internalStatesController?.dispose();
     super.dispose();
   }
 

diff --git a/packages/flutter/lib/src/widgets/scroll_position.dart b/packages/flutter/lib/src/widgets/scroll_position.dart
@@ -976,6 +976,7 @@ abstract class ScrollPosition extends ViewportOffset with ScrollMetrics {
   void dispose() {
     activity?.dispose(); // it will be null if it got absorbed by another ScrollPosition
     _activity = null;
+    isScrollingNotifier.dispose();
     super.dispose();
   }