_RawAutocompleteState should dispose _highlightedOptionIndex. (#133700)

engine-flutter-autoroll · Aug 30, 2023 · 95e197b · 95e197b
1 parent 31600c8
commit 95e197b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/flutter/lib/src/widgets/autocomplete.dart b/packages/flutter/lib/src/widgets/autocomplete.dart
@@ -565,6 +565,7 @@ class _RawAutocompleteState<T extends Object> extends State<RawAutocomplete<T>>
     _floatingOptions?.remove();
     _floatingOptions?.dispose();
     _floatingOptions = null;
+    _highlightedOptionIndex.dispose();
     super.dispose();
   }
 

diff --git a/packages/flutter/test/material/autocomplete_test.dart b/packages/flutter/test/material/autocomplete_test.dart
@@ -5,6 +5,7 @@
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
 
 class User {
   const User({
@@ -45,7 +46,8 @@ void main() {
     User(name: 'Charlie', email: '[email protected]'),
   ];
 
-  testWidgets('can filter and select a list of string options', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('can filter and select a list of string options', (WidgetTester tester) async {
+
     late String lastSelection;
     await tester.pumpWidget(
       MaterialApp(