Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base64): Ponyfill on XSnap #889

Merged
merged 1 commit into from
Sep 16, 2021
Merged

feat(base64): Ponyfill on XSnap #889

merged 1 commit into from
Sep 16, 2021

Conversation

kriskowal
Copy link
Member

@kriskowal kriskowal requested a review from dckc September 14, 2021 00:15
@kriskowal kriskowal force-pushed the kris-xsnap-base64 branch 2 times, most recently from 719fa64 to fba9543 Compare September 14, 2021 00:29
dckc
dckc approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking on each call could be improved by checking when the function is defined, but I don't suppose that would make a measurable difference.

@kriskowal
Copy link
Member Author

Checking on each call could be improved by checking when the function is defined, but I don't suppose that would make a measurable difference.

How can one deny the voice of one’s own conscience made manifest?

@kriskowal kriskowal merged commit f4f10e2 into master Sep 16, 2021
@kriskowal kriskowal deleted the kris-xsnap-base64 branch September 16, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kriskowal @dckc