Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ses)!: Third-party module exports #668

Merged
merged 4 commits into from
Apr 16, 2021
Merged

feat(ses)!: Third-party module exports #668

merged 4 commits into from
Apr 16, 2021

Conversation

kriskowal
Copy link
Member

BREAKING CHANGE Third-party static module interface implementations must now explicitly list their exported names. For CommonJS, this implies using a heuristic static analysis of exports changes. Consequently, third-party modules can now participate in linkage with ESM including support for export * from './spec.cjs' and also named imports like import * from './spec.cjs'.

Part 1 of #666

@kriskowal kriskowal disabled auto-merge April 15, 2021 21:54
@kriskowal kriskowal force-pushed the 655-ses branch 2 times, most recently from 37b20a8 to e03a577 Compare April 15, 2021 22:14
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriskowal kriskowal merged commit f0ec398 into master Apr 16, 2021
@kriskowal kriskowal deleted the 655-ses branch April 16, 2021 18:58
@kriskowal kriskowal linked an issue Apr 16, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore CommonJS to CompartmentMapper
2 participants