compartment-mapper: Temporarily disable CommonJS #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
approved these changes
Oct 23, 2020
| }; | ||
|
|
||
| const fixtureAssertionCount = 11; | ||
| const fixtureAssertionCount = 6; |
There was a problem hiding this comment.
Ever more eager for ava, to make this t.plan stuff go away. These manually maintained numbers are awful.
Just editorial venting. No change needed to this PR.
kriskowal
force-pushed
the
kris/temp-no-cjs
branch
3 times, most recently
from
c0aaac4 to
b01ee06
Compare
kriskowal
force-pushed
the
kris/temp-no-cjs
branch
from
b01ee06 to
5736c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change temporarily removes CommonJS support from Compartment Mapper to relieve a dependency on Babel that entrained a Node.js builtin, which in turn did not compose well between Rollup and RESM. This should unblock integration in Agoric SDK.
Continued work would begin with reverting this change and adding a CommonJS static analyzer based on a small and fast lexer that captures both imports and exports metadata, consistent with the lexer used by Node.js for exports analysis.
https://github.com/Agoric/SES-shim/compare/kris/restore-cm-cjs