test(daemon): Refactor daemon test suite #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
changed the title
Progresses #2125 Extracts locator setup into utility function and adds test teardown that will always run, except in cases of multiple locators being created. The multiple locator case will be handled in a follow-up. This fully resolves #2125, except in cases where tests that create multiple locators fail.
rekmarks
force-pushed
the
rekmarks-daemon-test-refactor
branch
from
75c4fc6
to
ceba6e2
Compare
rekmarks
force-pushed
the
rekmarks-daemon-test-refactor
branch
from
ceba6e2
to
004d46a
Compare
rekmarks
force-pushed
the
rekmarks-daemon-test-refactor
branch
from
004d46a
to
c574333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2125
Refactors
test-endo.jsby introducing utilities to absorb the necessary boilerplate to get from an empty state to a reference to a live endo host. Also addresses #2125 by ensuring that test teardown will always run, even in the case of test failures. There should no longer be any dangling node processes after runningyarn test, and it may even be possible to forego the use oftest:cleanand itsrm -rf /tmpprelude in the general case.