fix(compartment-mapper): avoid mislabeling cjs files as esm based on type field 2 #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
kriskowal
approved these changes
Jul 18, 2022
naugtur
force-pushed
the
naugur-fix-cjs-misinterpretation2
branch
from
d448c48 to
d13f513
Compare
naugtur
force-pushed
the
naugur-fix-cjs-misinterpretation2
branch
from
d13f513 to
5a6a501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce assumptions about language vs extension into the makeExtensionParser function to prioritize resolving by extension and fall back to configured type only for ambiguous extensions (currently only js)
This looks nicer than version 1 but leaves invalid entries in
typesbeing ignored, but risking something else uses them.An alternative: #1231