More manifest and gradle templating #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --extra-manifest-xml and --extra-manifest-application-arguments options are currently only handled by the sdl2 bootstrap while the --manifest-placeholders option is handled in the common build.gradle template.
This allows having separate placeholders for debug and release builds. That can be useful for changing manifest features based on the build type.
This was referenced May 23, 2023
pwithnall
reviewed
May 24, 2023
dbnicholson
added a commit
to endlessm/kolibri-installer-android
that referenced
this pull request
May 24, 2023
Use the supported manifest metadata tags to disable Analytics and Crashlytics by default for debug builds. This uses a manifest placeholder to toggle the setting between debug and release builds. This depends on endlessm/python-for-android#18.
|
I'm going to assume that was a tacit approval and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire up some more templating in the generated
AndroidManifest.xmlandbuild.gradlefiles to support some features we want to use. I believe this can all be sent upstream, but I want to get it working downstream first.Needed for endlessm/kolibri-installer-android#125 and endlessm/kolibri-installer-android#128.