Skip to content

Commit

Permalink
Skip test-pull-repeated during CI
Browse files Browse the repository at this point in the history
This test is expected to fail a small proportion of the time. During
the build of ostree 2018.7-1 in Debian, it seems we were unlucky on
s390x. Non-deterministic tests are also problematic for autopkgtest,
where they can gate migration of our dependencies like GLib, so skip
this test unless the caller has opted-in to non-deterministic tests.

It would be appropriate to enable this test in environments where
failures can easily be retried and are not disruptive to other
packages.

Signed-off-by: Simon McVittie <[email protected]>
  • Loading branch information
smcv authored and dbnicholson committed Mar 19, 2021
1 parent 09b24be commit 090932d
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/test-pull-repeated.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ set -euo pipefail

. $(dirname $0)/libtest.sh

if [ "${OSTREE_TEST_ALLOW_RANDOM:-}" != 1 ]; then
skip "Non-deterministic test will fail if we are unlucky"
fi

COMMIT_SIGN=""
if has_gpgme; then
COMMIT_SIGN="--gpg-homedir=${TEST_GPG_KEYHOME} --gpg-sign=${TEST_GPG_KEYID_1}"
Expand Down

0 comments on commit 090932d

Please sign in to comment.