Podman build #3
Merged
Podman build #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been testing to build using podman with this change and it's working correctly for me. |
In podman, a user namespace is setup with IDs mapped such that the executing user is root in the container. When that's the case (or if docker is in use and the executing user is root), don't override the container user or the HOME environment variable. In that case, the container user's home directory will be /root, so mount the cache there instead of the predefined /cache.
dbnicholson
force-pushed
the
podman-build
branch
from
d32ca64 to
e70a05e
Compare
|
Rebased this now. We'll see if it breaks the CI... |
manuq
reviewed
Jun 22, 2022
| if [ "$BUILD_UID" -eq 0 ]; then | ||
| BUILD_CACHE_PATH=/root | ||
| else | ||
| BUILD_CACHE_PATH=/cache |
There was a problem hiding this comment.
Testing here. The changes in the --user parameter works for me. But the change in BUILD_CACHE_PATH is making the caching worse. I ran the build a second time and is taking ages. I will keep testing.
There was a problem hiding this comment.
Testing here. The changes in the
--userparameter works for me. But the change inBUILD_CACHE_PATHis making the caching worse. I ran the build a second time and is taking ages. I will keep testing.
I was wrong! This branch in fact reduces the successive builds to 1 minute. Great!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of learningequality#108. I was going to send this upstream, but maybe we should test it out here first. I successfully did a few podman and docker builds with it.