Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the SciGirls background asset #666

Closed
2 tasks
jofilizola opened this issue Jun 25, 2023 · 3 comments · Fixed by #688
Closed
2 tasks

Change the SciGirls background asset #666

jofilizola opened this issue Jun 25, 2023 · 3 comments · Fixed by #688
Assignees
@manuq
Labels
bug Something isn't working

Comments

@jofilizola
Copy link

We changed the theme background color, and now the asset doesn't match. New asset attached.
BG_SciGirls_2560x900

  • SciGirls in English ID: 1b1fc9bd453a4c52bb5628d9ae804ede\
  • SciGirls in Spanish ID: ee52db4a62a94e9683599af8782f2d03
@manuq manuq assigned manuq and unassigned dylanmccall Jun 28, 2023
manuq added a commit that referenced this issue Jun 28, 2023
@manuq
Scigirls override: Update header background
f18525a 
Resolves #666
@manuq manuq mentioned this issue Jun 28, 2023
Merged
@manuq
Copy link
Collaborator

manuq commented Jun 28, 2023

Ready for review. Note, I compressed the PNG because it was big (from 404K to 84K).

By the way, we are not showing these assets anymore in the new header design. Should we remove them all instead?

@manuq manuq added the bug Something isn't working label Jun 28, 2023
GeorgesStavracas pushed a commit that referenced this issue Jun 28, 2023
@manuq @GeorgesStavracas
Scigirls override: Update header background
2369fec 
Resolves #666
@erikos
Copy link
Contributor

erikos commented Jul 24, 2023

QA in Ladybird v6.30.0 (Vanessa and Simon)

We only see the default bg color, is that correct?

@jofilizola
Copy link
Author

We can leave as just the background color, that's fine. I will archive this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuq manuq

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scigirls override: Update header background endlessm/kolibri-explore-plugin
4 participants
@manuq @dylanmccall @erikos @jofilizola