Handle missing account icon & full name #1241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this property is empty, we don't want to prepend /var/run/host to it, since that will defeat the 'if icon_file' check just a few lines later.
str.split() has a special case when the separator is not provided, which
is actually more desirable. It is best demonstrated by example:
>>> "Will Thompson ".split(" ")
['Will', '', '', 'Thompson', '']
>>> "Will Thompson ".split()
['Will', 'Thompson']
>>> "".split(" ")
['']
>>> "".split()
[]
This change ensures that all elements of 'tokens' are non-empty.
If a user account's RealName property is empty, we would previously
crash while trying to pick the initials out of it:
Traceback (most recent call last):
File "/app/lib/python3.9/site-packages/eosclubhouse/clubhouse.py", line 3210, in do_activate
File "/app/lib/python3.9/site-packages/eosclubhouse/clubhouse.py", line 3374, in _ensure_window
File "/app/lib/python3.9/site-packages/eosclubhouse/clubhouse.py", line 2296, in __init__
File "/app/lib/python3.9/site-packages/eosclubhouse/clubhouse.py", line 2438, in update_user_info
IndexError: list index out of range
We would also set the empty string as the label for the user.
Fall back to the UserName, which is guaranteed to be non-empty, if
RealName is empty or all-whitespace.
(I encountered this problem in a WSL2 container, but the same problem
can be reproduced on any system.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use Clubhouse in a WSL2 container, I hit a few problems because my user account had no RealName (or IconFile) configured in Accounts Service. So here are three fixes: