Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM publish #6

Merged
merged 4 commits into from
Feb 2, 2024
Merged

NPM publish #6

merged 4 commits into from
Feb 2, 2024

Conversation

deobald
Copy link
Member

@deobald deobald commented Feb 2, 2024

Draft NPM publishing changes

* unfortunately, there's no nice way to put this workflow inside the
  /clients/javascript directory itself, so we have to use prefixes
  to namespace it.
* although there is an `npm --no-git-tag-version version from-git`
  option to set the version in package.json, it doesn't appear to
  work with pre-releases, for some undocumented reason ... the
  assertion that we've manually updated the version in package.json
  is just a sanity-check for now (though it does introduce a bit of a
  chicken-egg problem)

* installation and usage instructions are probably too verbose for
  real javascript devs ... these are mostly for me to refer to, as
  I've never used node-and-friends in earnest before. (can reduce
  later)
@deobald
Copy link
Member Author

deobald commented Feb 2, 2024

The workflow isn't running from a branch, so I'll merge this.

@deobald deobald merged commit 1d790d8 into main Feb 2, 2024
1 check failed
@deobald deobald deleted the npm-publish branch February 2, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant