tests: ignore coverage on helper test functions #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
changed the title
euri10
requested changes
May 28, 2021
tests/test_config.py
Outdated
| @@ -159,7 +159,7 @@ def test_ssl_config_combined(tls_certificate_pem_path): | |||
| assert config.is_ssl is True | |||
|
|
|||
|
|
|||
| def asgi2_app(scope): | |||
| def asgi2_app(scope): # pragma: no cover | |||
There was a problem hiding this comment.
this should not be skipped imho, we have code in config.py that makes the switch from asgi2 to asgi3 :
Lines 331 to 339 in d81b96e
There was a problem hiding this comment.
You're right. But the body of that function is not executed, because the __call__ on the ASGI2Middleware is never reached.
uvicorn/uvicorn/middleware/asgi2.py
Lines 5 to 7 in e6028a6
There was a problem hiding this comment.
I've updated and I'm now adding "pragma" on the exact lines that are needed. What do you think? @euri10
Co-authored-by: euri10 <[email protected]>
Co-authored-by: euri10 <[email protected]>
euri10
approved these changes
May 28, 2021
Kludex
added a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
* tests: ignore test lines * Update tests/supervisors/test_reload.py Co-authored-by: euri10 <[email protected]> * Update tests/supervisors/test_multiprocess.py Co-authored-by: euri10 <[email protected]> * precision on pragmas Co-authored-by: euri10 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll open several issues for #102
I don't think a single PR will be a good thing to do, but I can merge them in a single one if you think is the best.