Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brings back windows testing to CI #685
Brings back windows testing to CI #685
Changes from 40 commits
ff05849
a7671f7
1fd49ec
69483ad
2247f5d
d8c791c
1a83b67
942a20d
3519c54
007b114
1c630b7
7a6291c
a9f25f6
0e4d199
23efd52
bf05a87
a1e4587
8998fd7
69c4555
740d4c1
2efe2f1
60f4203
0558730
91a0402
b91d497
dd3d593
d94417b
bfc0558
1e535ef
561234e
0c1c280
54f7856
b1a62aa
d6c98d1
6ce7a55
18d20fa
659e5e3
9e83480
1128502
5ddb0a4
ed5896b
edd287f
8e37336
8a0c8be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon we should probably omit this. The
pipefail
is extraneous here, and would have already included-x
if had wanted that.We could potentially use
set -x
immediately prior running to the pip install commands, but let's treat that all as a separate PR and try to keep this as absolutely isolated as possible to "what do we need to do in order to support running the tests on windows".