Revert "Add test for uvicorn worker (#631)" #658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 44e7deb
I now think the previous behaviour was correct, and I've been confused by the use of the same timeout word in different contexts.
Add to that the fact that as rightly written in the gunicorn doc, the
-timeout
gunicorn flag purpose in the async case is not the same as in the sync case, it's only used to notify the Arbitrer that workers are still alive.To sum up the flow : when using gunicorn with the
-k
flag you basically spawn an Arbitrer, which spawns workers (UvicornWorker in our case), workers who need to notify the arbitrer before the -timeout
flag which defaults to 30s, if not they reboot.Now to do that, the UvicornWorker inherits the timeout from the gunicorn base Worker, and this timeout is de facto set at half the
-timeout
value by the Arbitrer when it spawns its workers, I was missing that part when I thought the gunicorn config was not passed down :so as soon as a UvicornWorker is initialized, it has its notification timeout set to that half and should we change the
-timeout
gunicorn flag it would be correctly reflected in the UvicornWorker configuration.