Fix coverage-conditional-plugin syntax #2004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The coverage-conditional-plugin allows code to be conditionally omitted from test coverage reports. The syntax can be confusing (wemake-services/coverage-conditional-plugin#188).
The
py-gte-39
rule is backwards.uvicorn/pyproject.toml
Lines 124 to 125 in 3737d66
The omit added in #2001 is backwards and isn't supported on version 0.8.0.
uvicorn/pyproject.toml
Lines 114 to 115 in 3737d66
uvicorn/requirements.txt
Line 23 in 3737d66
Coverage reports demonstrate this.
Changes
py-gte-39
rulecoverage-conditional-plugin==0.9.0
to support omit syntaxRelated
test_connection_lost_before_handshake_complete
#2001Checklist