Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only stop receiving stream on body_stream if body is empty #1940

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Only stop receiving stream on body_stream if body is empty #1940

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0482c0
Only stop receiving stream on `body_stream` if body is empty
Kludex Nov 8, 2022
a71b851
Update starlette/middleware/base.py
Kludex Nov 8, 2022
db631f9
Merge branch 'master' into fix/premature-cancellation
Kludex Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion starlette/middleware/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ async def body_stream() -> typing.AsyncGenerator[bytes, None]:
body = message.get("body", b"")
if body:
yield body
if not message.get("more_body", False):
elif not message.get("more_body", False):
break
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing those two lines also solves the issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed them instead.

Kludex marked this conversation as resolved.
Show resolved Hide resolved

if app_exc is not None:
Expand Down