Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send empty data to StreamingResponse on BaseHTTPMiddleware #1609

Merged
merged 6 commits into from
May 6, 2022
Merged

Do not send empty data to StreamingResponse on BaseHTTPMiddleware #1609

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2e8ab8f
Do not send empty data to `StreamingResponse` on `BaseHTTPMiddleware`
Kludex Apr 29, 2022
2046d75
Merge branch 'master' into no-more-body-2
Kludex Apr 30, 2022
56670c7
Merge branch 'master' into no-more-body-2
adriangb May 2, 2022
0551c61
Merge branch 'master' into no-more-body-2
Kludex May 4, 2022
7799412
Merge branch 'master' into no-more-body-2
tomchristie May 5, 2022
77a2a6b
Merge branch 'master' into no-more-body-2
Kludex May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion starlette/middleware/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ async def body_stream() -> typing.AsyncGenerator[bytes, None]:
async with recv_stream:
async for message in recv_stream:
assert message["type"] == "http.response.body"
yield message.get("body", b"")
body = message.get("body", b"")
if body:
yield body
if not message.get("more_body", False):
break

if app_exc is not None:
raise app_exc
Expand Down