Make content argument required to JSONResponse

starlette/responses.py

@@ -37,21 +37,25 @@ class Response:
     def __init__(
         self,
         content: typing.Any = None,
-        status_code: int = 200,
+        status_code: int = None,
         headers: dict = None,
         media_type: str = None,
         background: BackgroundTask = None,
     ) -> None:
-        self.status_code = status_code
         if media_type is not None:
             self.media_type = media_type
         self.background = background
-        self.body = self.render(content)
+
+        if content is None:
+            self.body = b""
+            self.status_code = status_code or 204
+        else:
+            self.body = self.render(content)
+            self.status_code = status_code or 200
+
         self.init_headers(headers)
 
     def render(self, content: typing.Any) -> bytes:
-        if content is None:
-            return b""
         if isinstance(content, bytes):
             return content
         return content.encode(self.charset)

tests/test_responses.py

@@ -38,12 +38,12 @@ async def app(scope, receive, send):
 
 def test_json_none_response(test_client_factory):
     async def app(scope, receive, send):
-        response = JSONResponse(None)
+        response = JSONResponse()
         await response(scope, receive, send)
 
     client = test_client_factory(app)
     response = client.get("/")
-    assert response.json() is None
+    assert response.content == b""
 
 
 def test_redirect_response(test_client_factory):
@@ -330,7 +330,8 @@ def test_empty_response(test_client_factory):
     app = Response()
     client: TestClient = test_client_factory(app)
     response = client.get("/")
-    assert response.headers["content-length"] == "0"
+    assert response.status_code == 204
+    assert "content-length" not in response.headers
 
 
 def test_empty_204_response(test_client_factory):